Re: [PATCH v2 2/3] arm64: dts: qcom: lemans: Add LeMans Draco EVK SoM platform

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: lemans-draco-som: swapped USB QMP PHY vdda
  supplies
--

commit 7b19f1db69f746d48a10a9095746a5c2e0b70d80
Author: Gopikishan Thawre <gopikishan.thawre@oss.qualcomm.com>

arm64: dts: qcom: lemans: Add LeMans Draco EVK SoM platform

This commit introduces the device tree for the SA8775P/QCS9100-based LeMans
Draco EVK SoM, including RPMH regulators, QUP, remoteproc, UART, UFS, USB,
GPU, and VPU nodes.

> diff --git a/arch/arm64/boot/dts/qcom/lemans-draco-som.dtsi b/arch/arm64/boot/dts/qcom/lemans-draco-som.dtsi
> new file mode 100644
> index 0000000000000..6b7971bcdc934
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/lemans-draco-som.dtsi

[ ... ]

> +&usb_0_qmpphy {
> +	vdda-phy-supply = <&vreg_l1c>;
> +	vdda-pll-supply = <&vreg_l7a>;
> +
> +	status = "okay";
> +};
> +
> +&usb_1 {
> +	dr_mode = "host";
> +
> +	status = "okay";
> +};
> +
> +&usb_1_hsphy {
> +	vdda-pll-supply = <&vreg_l7a>;
> +	vdda18-supply = <&vreg_l6c>;
> +	vdda33-supply = <&vreg_l9a>;
> +
> +	status = "okay";
> +};
> +
> +&usb_1_qmpphy {
> +	vdda-phy-supply = <&vreg_l1c>;
> +	vdda-pll-supply = <&vreg_l7a>;
> +
> +	status = "okay";
> +};

[Severity: Medium]
Are vdda-phy-supply and vdda-pll-supply swapped on usb_0_qmpphy and
usb_1_qmpphy?

vreg_l7a is the ~0.8V rail and vreg_l1c is the ~1.2V rail.  On SA8775P QMP
PHYs, vdda-phy-supply expects the ~0.8V rail and vdda-pll-supply expects the
~1.2V rail, as fixed on the other LeMans boards in 932113c3c778 ("arm64: dts:
qcom: lemans: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies").  Swapping
them programs the 21800 uA vdda-phy load on vreg_l1c and the 36000 uA
vdda-pll load on vreg_l7a.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-lemans-draco-final-changes-bringup-v2-0-3ae8cd1c9932@oss.qualcomm.com?part=2