Re: [PATCH net-next 2/6] bonding: finish XDP setup before publishing the slave

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] bonding: missing Fixes trailers for bond_enslave() XDP error
  leaks
--

commit 48b54e99e17c93fa370e6459ec403b3e7a7d7c19
Author: Hangbin Liu <hangbin.liu@linux.dev>

> bonding: finish XDP setup before publishing the slave
>
> bond_enslave() currently runs the fallible XDP setup
> (dev_xdp_propagate()) after the slave has already been published:
> slave_cnt is incremented, ns maddrs are added and the active slave
> may have been selected. If XDP setup then fails, the error path
> jumps to err_sysfs_del and leaks:
>
>   - the promiscuity/allmulti increments and synced addresses applied
>     to the slave earlier in the function, which are only undone on
>     an immediate allmulti failure,
>   - the ns maddrs added just before the failure, which no enslave
>     error path ever removes.
>
> Move dev_xdp_propagate() to the last fallible step, right after the
> promiscuity/allmulti/address-sync block and before
> WRITE_ONCE(bond->slave_cnt), so that no handled fallible call
> follows the publication of the slave and a failure can no longer
> leak slave_cnt or ns maddrs.
>
> bond_xdp_set_features() is moved along with this reordering so XDP
> features are updated before the slave is published. Route the XDP
> failure through a new err_set_xdp label that undoes the promiscuity,
> allmulti and address-sync state, mirroring what __bond_release_one()
> does.
>
> Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>

[Severity: Low]
Since this fixes the promiscuity/allmulti/address-sync and IPv6 NS
target multicast address leaks on the XDP setup failure path in
bond_enslave(), should the commit message include Fixes tags?

  Fixes: 9e2ee5c7e7c3 ("net, bonding: Add XDP support to the bonding driver")
  Fixes: 8eb36164d1a6 ("bonding: add ns target multicast address to slave device")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-bond_enslave_restruct-v1-0-364c549e78db@kylinos.cn?part=2