From: sashiko-bot@kernel.org
To: "Bryam Vargas" <hexlabsecurity@proton.me>
Cc: linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH net] net/smc: set the lkey of every SGE in smcr_tx_rdma_writes()
Date: Sat, 14 Nov 2026 14:25:08 +0000 [thread overview]
Message-ID: <sashiko-outbox-214630@kernel.org> (raw)
In-Reply-To: <20261114-b4-disp-dd99cd41-v1-1-009e1c022346@proton.me>
> From: Bryam Vargas <hexlabsecurity@proton.me>
>
> smcr_tx_rdma_writes() sets the lkey of an SGE only for a virtually
> contiguous send buffer; for a physically contiguous one it leaves the
> lkey the work request slot already holds. With net.smc.smcr_buf_type=2
> a send buffer falls back to vzalloc() when alloc_pages() fails, so one
> link carries both kinds, and a slot last used by a virtually contiguous
> buffer posts the DMA address of a physically contiguous one under the
> earlier buffer's MR lkey. That write fails, the link goes down and,
> with no link to switch to, the link group is terminated with all of
> its connections.
>
> Set the lkey on both branches: the MR's for a virtually contiguous
> buffer, local_dma_lkey otherwise.
>
> Fixes: b8d199451c99 ("net/smc: Allow virtually contiguous sndbufs or RMBs for SMC-R")
> Cc: stable@vger.kernel.org
> Signed-off-by: Bryam Vargas <hexlabsecurity@proton.me>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261114-b4-disp-dd99cd41-v1-1-009e1c022346@proton.me?part=1
prev parent reply other threads:[~2026-11-14 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 14:14 [PATCH net] net/smc: set the lkey of every SGE in smcr_tx_rdma_writes() Bryam Vargas
2026-11-14 14:14 ` Bryam Vargas via B4 Relay
2026-11-14 14:25 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-214630@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hexlabsecurity@proton.me \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.