Re: [PATCH 1/2] PCI: meson: Power the PHY on and reset the controller in host .init

[sashiko-bot@kernel.org]

> From: Igor Velkov <iav@iav.lv>
> 
> Move the PHY power on and the PHY and controller reset from probe into
> the host .init callback, and add a .deinit that asserts PERST# and
> powers the PHY off, and a .stop_link that disables the LTSSM.
> dw_pcie_host_init() calls .deinit on a later probe error and
> dw_pcie_host_deinit() calls it at remove, so probe and remove do not
> power the PHY off themselves.
> 
> This prepares for system suspend, where dw_pcie_suspend_noirq() and
> dw_pcie_resume_noirq() run the same callbacks.
> 
> It also changes the order in probe: the clocks are enabled before the
> PHY is powered on and the controller is reset.  Resume runs .init with
> the clocks still on, so both take the same order.
> 
> Signed-off-by: Igor Velkov <iav@iav.lv>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114-b4-pci-meson-suspend-v1-0-be3d04a13304@iav.lv?part=1