Re: [PATCH v3 05/16] HID: ft260: fix sysfs store failure notice for big numbers

[sashiko-bot@kernel.org]

> FT260_ATTR_STORE returned the feature-report transfer length from
> ft260_hid_feature_report_set() instead of the sysfs write size. For
> values like 1000, userspace writes more bytes than the HID report
> length, so the VFS retries the remainder and reports "Invalid argument"
> even though the attribute was applied correctly:
> 
>   $ echo 1000 > .../clock
>   bash: line 1: echo: write error: Invalid argument
>   $ cat .../clock
>   1000
> 
> Return count when the feature report succeeds, so the full write is
> consumed, and the error when it fails.
> 
> Parse a 16-bit attribute, such as clock, into a u16 and convert it with
> cpu_to_le16(), because the report field is little endian. Before, the
> value was parsed straight into the __le16 field, which is wrong on a
> big-endian CPU.
> 
> Signed-off-by: Michael Zaidman <michael.zaidman@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114230800.1344401-1-michael.zaidman@gmail.com?part=5