From: sashiko-bot@kernel.org
To: "Artem Novak" <artem122novak@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH net 2/2] net: usb: smsc95xx: propagate MDIO write errors
Date: Sun, 15 Nov 2026 05:10:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-215233@kernel.org> (raw)
In-Reply-To: <20261114050954.275495-3-artem122novak@gmail.com>
> The MDIO write helper currently discards register access errors,
> and the MDIO bus callback consequently reports success even when
> a write fails.
>
> Return the error from the helper and propagate it through the
> MDIO bus callback. Continue treating -ENODEV as success during
> device disconnect, consistent with the MDIO read path.
>
> Fixes: 05b35e7eb9a1 ("smsc95xx: add phylib support")
> Signed-off-by: Artem Novak <artem122novak@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261114050954.275495-1-artem122novak@gmail.com?part=2
next prev parent reply other threads:[~2026-11-15 5:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 5:09 [PATCH net 0/2] net: usb: smsc95xx: propagate MDIO errors Artem Novak
2026-11-14 5:09 ` [PATCH net 1/2] net: usb: smsc95xx: propagate MDIO reset errors Artem Novak
2026-11-14 22:08 ` Andrew Lunn
2026-11-14 22:12 ` Artem Novak
2026-11-15 5:10 ` sashiko-bot
2026-11-15 5:21 ` netdev-bot+sashiko
2026-11-14 5:09 ` [PATCH net 2/2] net: usb: smsc95xx: propagate MDIO write errors Artem Novak
2026-11-14 22:10 ` Andrew Lunn
2026-11-14 22:13 ` Artem Novak
2026-11-15 5:10 ` sashiko-bot [this message]
2026-11-15 5:21 ` netdev-bot+sashiko
2026-11-14 5:12 ` [PATCH net 0/2] net: usb: smsc95xx: propagate MDIO errors netdev-bot+sinfo
2026-11-14 5:18 ` Artem Novak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215233@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=artem122novak@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.