Re: [PATCH v2 1/2] dt-bindings: iio: chemical: Add Sensirion SGP41 binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [Medium] dt-bindings: iio: chemical: sgp41: missing vddh-supply for
  heater pin
- [Low] dt-bindings: iio: chemical: sgp41: 2-space example indent and
  const reg
- [Low] dt-bindings: iio: chemical: sgp41: deprecated GPL-2.0 SPDX
  license tag
--

commit 364f23f4f9b681d905ad97232d6cdcac6d5b17e4
Author: Akshat Chandra <notmissinge@gmail.com>

dt-bindings: iio: chemical: Add Sensirion SGP41 binding

This commit adds a Device Tree binding schema for the Sensirion SGP41 VOC
and NOx I2C gas sensor.

> diff --git a/Documentation/devicetree/bindings/iio/chemical/sensirion,sgp41.yaml b/Documentation/devicetree/bindings/iio/chemical/sensirion,sgp41.yaml
> new file mode 100644
> index 0000000000000..c2bb6818f4390
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/chemical/sensirion,sgp41.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

[Severity: Low]
Should this use (GPL-2.0-only OR BSD-2-Clause) instead of the deprecated
GPL-2.0 identifier, per Documentation/devicetree/bindings/submitting-patches.rst?

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/chemical/sensirion,sgp41.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sensirion SGP41 VOC and NOx gas sensor
> +
> +maintainers:
> +  - Akshat Chandra <notmissinge@gmail.com>
> +
> +description: |
> +  Sensirion SGP41 indoor air quality sensor measuring raw VOC and NOx
> +  signals over I2C.
> +
> +properties:
> +  compatible:
> +    const: sensirion,sgp41
> +
> +  reg:
> +    const: 0x59
> +
> +  vdd-supply: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +additionalProperties: false

[Severity: Medium]
Should the schema also define vddh-supply?

The SGP41 has a dedicated VDDH pin for the hotplate heater supply in
addition to the logic VDD pin.  Boards that power VDD (for example at
1.8 V for I2C) and VDDH from separate regulators cannot describe
vddh-supply in Device Tree when additionalProperties is false without
failing dtbs_check.

> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      gas-sensor@59 {
> +        compatible = "sensirion,sgp41";
> +        reg = <0x59>;
> +        vdd-supply = <&vdd>;
> +      };
> +    };

[Severity: Low]
The example uses 2-space indentation instead of 4 spaces per level, which
triggers an indent-unit-strict warning from scripts/dtc/dt-check-style.
Also, should reg in properties use maxItems: 1 rather than const: 0x59 to
follow standard IIO binding conventions and allow I2C address translation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115055941.362185-1-notmissinge@gmail.com?part=1