Re: [PATCH net] net/mlx5e: Fix XSK pool corruption when switching channels

[sashiko-bot@kernel.org]

> From: Gal Pressman <gal@nvidia.com>
> 
> When the device supports tis_tir_td_order, mlx5e_safe_switch_params()
> closes the old channels only after the new ones are activated.  With an
> AF_XDP socket bound, the old and the new channel hold an XSK RQ on the
> same pool.
> 
> The old RQ returns its buffers to the pool while the new RQ is already
> allocating from it. Since the pool is lockless and expects a single user
> at a time, it gets out of sync.
> 
> Close the old XSK queues before activating the new channels, the rest of
> the old channels can still be closed later.
> 
> The crash was hit by our regression tests, with a random sequence of
> [ ... ]
> 
> Fixes: 3b88a535a8e1 ("net/mlx5e: Defer channels closure to reduce interface down time")
> Signed-off-by: Gal Pressman <gal@nvidia.com>
> Reviewed-by: Nimrod Oren <noren@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115072934.353341-1-tariqt@nvidia.com?part=1