Re: [PATCH] leds: lm3642: Fix container_of() member confusion in pin attributes

[sashiko-bot@kernel.org]

> The strobe_pin and torch_pin sysfs attributes are registered on the
> flash and torch LED class devices respectively, but their store
> callbacks recover the chip data by container_of() on cdev_indicator.
> 
> dev_get_drvdata() in the attribute callbacks returns the led_classdev
> that owns the attribute group:
> 
>   - strobe_pin is in lm3642_flash_groups, so drvdata is &chip->cdev_flash
>   - torch_pin is in lm3642_torch_groups, so drvdata is &chip->cdev_torch
> 
> Both strobe_pin_store() and torch_pin_store() however use
> container_of(led_cdev, struct lm3642_chip_data, cdev_indicator).
> 
> cdev_indicator comes after cdev_flash and cdev_torch in struct
> lm3642_chip_data, so the resulting pointer lands before the start of
> [ ... ]
> no in-tree board provides lm3642 platform data.
> 
> Fixes: 8b7cfbec052d ("leds: Add new LED driver for lm3642 chips")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ziheng Wei <zihengw03@163.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115080213.910112-1-zihengw03@163.com?part=1