Re: [PATCH v3 2/2] dt-bindings: i2c: rtl9300: add 'rtl9607c-i2c'

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: i2c: rtl9301: per-compatible conditional pile-up
  for rtl9607c
--

commit 43c34d3c3c011204c713fd4d1ed08c55685b830d
Author: Michael Zavertkin <misha.zavertkin@mail.ru>

dt-bindings: i2c: rtl9300: add 'rtl9607c-i2c'

This commit adds the realtek,rtl9607c-i2c compatible string with required
clocks and pinctrl properties, and deprecates realtek,rtl9607-i2c.

> diff --git a/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml b/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml
> index 5873cfdc5b3e0..7c00918f33c8d 100644
> --- a/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml

[ ... ]

> @@ -57,6 +61,10 @@ properties:
>    clocks:
>      maxItems: 1
>  
> +  pinctrl-0: true
> +
> +  pinctrl-names: true
> +
>  patternProperties:
>    '^i2c@[0-9ab]$':
>      $ref: /schemas/i2c/i2c-controller.yaml
> @@ -96,6 +104,16 @@ allOf:
>        required:
>          - realtek,scl
>          - clocks
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: realtek,rtl9607c-i2c
> +    then:
> +      required:
> +        - clocks
> +        - pinctrl-0
> +        - pinctrl-names
>  
>  required:
>    - compatible

[Severity: Low]
Would it be cleaner to split realtek,rtl9607c-i2c into a separate schema
document rather than adding a fourth per-compatible if-then block to
allOf?

Unlike RTL9300 and RTL9310, which multiplex 8 or 12 shared SDA lines across
controllers and select the SCL line via realtek,scl, RTL9607C has a single
SCL/SDA pair per controller and uses pinctrl instead of realtek,scl.
Keeping realtek,rtl9607c-i2c in this shared schema also leaves the unused
realtek,scl property and multi-channel i2c@[0-9ab] child nodes permitted
for it.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1794728344.git.misha.zavertkin@mail.ru?part=2