Re: [PATCH v2 08/13] pinctrl: berlin: add Synaptics SL2610 pin controller support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] pinctrl: berlin: wrong pad config offset 0x87c for GPIO54 on
  SL2610
--

commit b2ae5372019c8928361d53ac7a361789c010c9c3
Author: Jisheng Zhang <jszhang@kernel.org>

pinctrl: berlin: add Synaptics SL2610 pin controller support

This commit adds the pin controller driver for Synaptics SL2610 SoCs,
defining the SoC and MCU pin groups, mux functions, and pad configuration
register offsets.

> diff --git a/drivers/pinctrl/berlin/pinctrl-sl2610.c b/drivers/pinctrl/berlin/pinctrl-sl2610.c
> new file mode 100644
> index 0000000000000..0a3dc146c2c01
> --- /dev/null
> +++ b/drivers/pinctrl/berlin/pinctrl-sl2610.c
> @@ -0,0 +1,759 @@

[ ... ]

> +static const struct berlin_desc_group sl2610_soc_pinctrl_groups[] = {

[ ... ]

> +	BERLIN_PINCTRLCONF_GROUP("GPIO53", 0x800c, 0x3, 0x00,
> +			0x8878, 10,
> +			BERLIN_PINCTRL_FUNCTION(0x0, "gpio"), /* GPIO53 */
> +			BERLIN_PINCTRL_FUNCTION(0x1, "rgmii2"), /* RD1 */
> +			BERLIN_PINCTRL_FUNCTION(0x6, "spi4"), /* SS3n */
> +			BERLIN_PINCTRL_FUNCTION(0x7, "spi3")), /* SCLK */
> +	BERLIN_PINCTRLCONF_GROUP("GPIO54", 0x800c, 0x3, 0x03,
> +			0x87c, 10,
> +			BERLIN_PINCTRL_FUNCTION(0x0, "gpio"), /* GPIO54 */
> +			BERLIN_PINCTRL_FUNCTION(0x1, "rgmii2"), /* RD2 */
> +			BERLIN_PINCTRL_FUNCTION(0x7, "spi3")), /* SDI */
> +	BERLIN_PINCTRLCONF_GROUP("GPIO55", 0x800c, 0x3, 0x06,
> +			0x8880, 10,
> +			BERLIN_PINCTRL_FUNCTION(0x0, "gpio"), /* GPIO55 */
> +			BERLIN_PINCTRL_FUNCTION(0x1, "rgmii2"), /* RD3 */
> +			BERLIN_PINCTRL_FUNCTION(0x5, "spi5"), /* SDI */
> +			BERLIN_PINCTRL_FUNCTION(0x7, "spi4")), /* SS1n */

[Severity: Medium]
Should the pad configuration offset for GPIO54 be 0x887c instead of 0x87c?
All other entries in sl2610_soc_pinctrl_groups place conf_offset at 4-byte
intervals in the 0x8800..0x88ec range, so configuring pad parameters for
GPIO54 will read and modify offset 0x87c in the parent syscon regmap while
leaving GPIO54's pad unconfigured.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115102401.3520-1-jszhang@kernel.org?part=8