From: sashiko-bot@kernel.org
To: "Oleg Nesterov" <oleg@redhat.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 net-next 4/5] net/rds/tcp.c: move sysctl-only code under CONFIG_SYSCTL
Date: Sun, 15 Nov 2026 13:32:44 +0000 [thread overview]
Message-ID: <sashiko-outbox-215532@kernel.org> (raw)
In-Reply-To: <avmywjLAQO-9fhw5@redhat.com>
> Collect all code used only when CONFIG_SYSCTL=y into a single block and
> wrap it in #ifdef CONFIG_SYSCTL. rds_tcp_init_net_sysctl no longer needs
> the IS_ENABLED() check.
>
> Add the corresponding init/exit stubs for the CONFIG_SYSCTL=n case.
>
> Also #ifdef the rds_tcp_sysctl and ctl_table fields in struct rds_tcp_net.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/avmymGvelu00X5EH@redhat.com?part=4
next prev parent reply other threads:[~2026-11-15 13:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 13:24 [PATCH v2 net-next 0/5] net/rds: move sysctl-only code under CONFIG_SYSCTL Oleg Nesterov
2026-11-15 13:25 ` [PATCH v2 net-next 1/5] net/rds/sysctl.c: " Oleg Nesterov
2026-11-15 13:32 ` sashiko-bot
2026-11-15 13:25 ` [PATCH v2 net-next 2/5] net/rds/ib_sysctl.c: " Oleg Nesterov
2026-11-15 13:32 ` sashiko-bot
2026-11-15 13:25 ` [PATCH v2 net-next 3/5] net/rds/tcp.c: introduce rds_tcp_{init,exit}_net_sysctl() helpers Oleg Nesterov
2026-11-15 13:32 ` sashiko-bot
2026-11-15 13:25 ` [PATCH v2 net-next 4/5] net/rds/tcp.c: move sysctl-only code under CONFIG_SYSCTL Oleg Nesterov
2026-11-15 13:32 ` sashiko-bot [this message]
2026-11-15 13:25 ` [PATCH v2 net-next 5/5] net/rds: remove dead sysctl declarations Oleg Nesterov
2026-11-15 13:32 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215532@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.