From: sashiko-bot@kernel.org
To: "Olivier Louvignes" <olivier@mgcrea.io>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 4/7] dt-bindings: power: supply: axp20x-usb-power: Add the AXP2101
Date: Sun, 15 Nov 2026 17:19:27 +0000 [thread overview]
Message-ID: <sashiko-outbox-215675@kernel.org> (raw)
In-Reply-To: <20261115171150.64431-5-olivier@mgcrea.io>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: power: supply: piling per-compatible if-then onto
axp20x schema
--
commit b91180032c14c7d6f98055be9d7c8629fe0f89d7
Author: Olivier Louvignes <olivier@mgcrea.io>
dt-bindings: power: supply: axp20x-usb-power-supply: Add the AXP2101
This commit adds the x-powers,axp2101-usb-power-supply compatible string
and its supported input-current-limit-microamp values to the AXP20x USB
power supply Device Tree binding schema.
> diff --git a/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml b/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml
> index 2ec036405ae47..439b3ea6a7f5b 100644
> --- a/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-usb-power-supply.yaml
> @@ -25,6 +25,7 @@ properties:
> - x-powers,axp223-usb-power-supply
> - x-powers,axp717-usb-power-supply
> - x-powers,axp813-usb-power-supply
> + - x-powers,axp2101-usb-power-supply
> - items:
> - const: x-powers,axp803-usb-power-supply
> - const: x-powers,axp813-usb-power-supply
> @@ -101,4 +102,15 @@ allOf:
> enum: [100000, 500000, 900000, 1500000, 2000000, 2500000,
> 3000000, 3500000, 4000000]
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - x-powers,axp2101-usb-power-supply
> + then:
> + properties:
> + input-current-limit-microamp:
> + enum: [100000, 500000, 900000, 1000000, 1500000, 2000000]
> +
> additionalProperties: false
[Severity: Low]
This schema only defines compatible and input-current-limit-microamp, yet
allOf now has six separate per-compatible if-then blocks because almost
every AXP variant supports a different set of current limits. Should this
binding be split into separate schema documents rather than piling on more
per-variant conditionals?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261115171150.64431-1-olivier@mgcrea.io?part=4
next prev parent reply other threads:[~2026-11-15 17:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 17:11 [PATCH v2 0/7] Add support for the X-Powers AXP2101 PMIC Olivier Louvignes
2026-11-15 17:11 ` [PATCH v2 1/7] dt-bindings: mfd: x-powers,axp152: Add the AXP2101 Olivier Louvignes
2026-11-15 17:20 ` sashiko-bot
2026-11-16 12:38 ` Krzysztof Kozlowski
2026-11-15 17:11 ` [PATCH v2 2/7] mfd: axp20x: Add support for " Olivier Louvignes
2026-11-15 17:11 ` [PATCH v2 3/7] regulator: " Olivier Louvignes
2026-11-15 17:11 ` [PATCH v2 4/7] dt-bindings: power: supply: axp20x-usb-power: Add " Olivier Louvignes
2026-11-15 17:19 ` sashiko-bot [this message]
2026-11-16 12:38 ` Krzysztof Kozlowski
2026-11-15 17:11 ` [PATCH v2 5/7] power: supply: axp20x_usb_power: Add support for " Olivier Louvignes
2026-11-15 17:11 ` [PATCH v2 6/7] dt-bindings: power: supply: axp20x-battery: Add " Olivier Louvignes
2026-11-15 17:11 ` [PATCH v2 7/7] power: supply: axp20x_battery: Add support for " Olivier Louvignes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215675@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=olivier@mgcrea.io \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.