From: sashiko-bot@kernel.org
To: "Aviv Bakal" <avivb@amazon.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/3] PCI: Avoid runtime D3 on Amazon PCIe switch ports
Date: Sun, 15 Nov 2026 17:27:49 +0000 [thread overview]
Message-ID: <sashiko-outbox-215679@kernel.org> (raw)
In-Reply-To: <20261115171831.1498006-3-avivb@amazon.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] PCI: quirk_amazon_bridge_no_d3() duplicates quirk_no_ata_d3()
--
commit 23d17d7ee035a77b0f0e403734f5f387abceea6d
Author: Aviv Bakal <avivb@amazon.com>
PCI: Avoid runtime D3 on Amazon PCIe switch ports
This commit adds an early PCI fixup quirk to set PCI_DEV_FLAGS_NO_D3 on
Amazon PCIe bridges so they do not enter runtime D3hot where PME# is not
asserted for hotplug events.
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 7f1f47ea2ee41..292047804b09b 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -1476,6 +1476,18 @@ DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_AL, PCI_ANY_ID,
> DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_VIA, PCI_ANY_ID,
> PCI_CLASS_STORAGE_IDE, 8, quirk_no_ata_d3);
>
> +/*
> + * Amazon 1d0f PCIe switch ports (e.g. 1d0f:cec2) on AWS instances
> + * advertise PME# from D3hot but never assert it, so hotplug events on
> + * a port in D3 are lost.
> + */
> +static void quirk_amazon_bridge_no_d3(struct pci_dev *pdev)
> +{
> + pdev->dev_flags |= PCI_DEV_FLAGS_NO_D3;
> +}
> +DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_AMAZON, PCI_ANY_ID,
> + PCI_CLASS_BRIDGE_PCI, 8, quirk_amazon_bridge_no_d3);
[Severity: Low]
This isn't a bug, but quirk_no_ata_d3() right above has the exact same body
(pdev->dev_flags |= PCI_DEV_FLAGS_NO_D3;) and relies on
DECLARE_PCI_FIXUP_CLASS_EARLY() for class matching. Could quirk_no_ata_d3()
be renamed to quirk_no_d3() and reused here, matching generic helpers like
quirk_no_bus_reset() and quirk_no_flr() later in this file?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261115171831.1498006-1-avivb@amazon.com?part=2
next prev parent reply other threads:[~2026-11-15 17:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 17:18 [PATCH 0/3] PCI/PM: Keep hotplug ports that can't wake from D3hot out of D3 Aviv Bakal
2026-11-15 17:18 ` [PATCH 1/3] PCI/PM: Honor PCI_DEV_FLAGS_NO_D3 in pci_bridge_d3_possible() Aviv Bakal
2026-11-15 17:39 ` sashiko-bot
2026-11-15 17:18 ` [PATCH 2/3] PCI: Avoid runtime D3 on Amazon PCIe switch ports Aviv Bakal
2026-11-15 17:27 ` sashiko-bot [this message]
2026-11-15 17:18 ` [PATCH 3/3] PCI/PM: Keep hotplug ports out of D3 if they can't signal PME from D3hot Aviv Bakal
2026-11-15 17:41 ` sashiko-bot
2026-11-15 17:22 ` [PATCH 0/3] PCI/PM: Keep hotplug ports that can't wake from D3hot out of D3 Lukas Wunner
2026-11-16 16:55 ` Aviv Bakal
2026-11-16 17:03 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215679@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=avivb@amazon.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.