From: sashiko-bot@kernel.org
To: "Suraj Gupta" <suraj.gupta2@amd.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH net-next v5 1/6] net: xilinx: axienet: Introduce axienet_config for MAC-specific ops
Date: Sun, 15 Nov 2026 18:31:33 +0000 [thread overview]
Message-ID: <sashiko-outbox-215720@kernel.org> (raw)
In-Reply-To: <20261114182947.2908628-2-suraj.gupta2@amd.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] net: xilinx: axienet: axienet_probe() fails on software-node
devices
--
commit 783576cb6315304b083793b1e0a0ea48b15baa81
Author: Suraj Gupta <suraj.gupta2@amd.com>
net: xilinx: axienet: Introduce axienet_config for MAC-specific ops
This commit introduces struct axienet_config to abstract MAC-specific
capabilities and callbacks, populating it from axienet_of_match and
converting the shared paths to use it.
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 7e83c4b5f1931..125ad3dbf6aa9 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
[ ... ]
> @@ -2898,27 +3046,13 @@ static int axienet_probe(struct platform_device *pdev)
> seqcount_mutex_init(&lp->hw_stats_seqcount, &lp->stats_lock);
> INIT_DEFERRABLE_WORK(&lp->stats_work, axienet_refresh_stats);
>
> - lp->axi_clk = devm_clk_get_optional_enabled(&pdev->dev,
> - "s_axi_lite_clk");
> - if (!lp->axi_clk) {
> - /* For backward compatibility, if named AXI clock is not present,
> - * treat the first clock specified as the AXI clock.
> - */
> - lp->axi_clk = devm_clk_get_optional_enabled(&pdev->dev, NULL);
> - }
> - if (IS_ERR(lp->axi_clk))
> - return dev_err_probe(&pdev->dev, PTR_ERR(lp->axi_clk),
> - "could not get AXI clock\n");
> -
> - lp->misc_clks[0].id = "axis_clk";
> - lp->misc_clks[1].id = "ref_clk";
> - lp->misc_clks[2].id = "mgt_clk";
> + lp->axienet_config = device_get_match_data(&pdev->dev);
> + if (!lp->axienet_config)
> + return -ENODEV;
[Severity: High]
Does this break probing for platform devices matched by driver name and
backed by a software_node, such as those registered after commits
f5185ec79dac ("net: axienet: use device_property and fwnode APIs for
probe-time config") and 418149559ef3 ("net: axienet: add a MODULE_ALIAS
for platform instantiation")?
software_node_ops does not implement .device_get_match_data and
axienet_driver has no id_table, so device_get_match_data() returns NULL on
non-OF platform devices and axienet_probe() now fails with -ENODEV instead
of defaulting to axienet_1g_config.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261114182947.2908628-1-suraj.gupta2@amd.com?part=1
next prev parent reply other threads:[~2026-11-15 18:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 18:29 [PATCH net-next v5 0/6] net: xilinx: axienet: Add 10G/25G (XXV) ethernet support Suraj Gupta
2026-11-14 18:29 ` [PATCH net-next v5 1/6] net: xilinx: axienet: Introduce axienet_config for MAC-specific ops Suraj Gupta
2026-11-15 18:31 ` sashiko-bot [this message]
2026-11-16 4:12 ` netdev-bot+sashiko
2026-11-14 18:29 ` [PATCH net-next v5 2/6] dt-bindings: net: xlnx,xxv-ethernet: Add Xilinx XXV 10G/25G Ethernet Suraj Gupta
2026-11-16 4:12 ` netdev-bot+sashiko
2026-11-14 18:29 ` [PATCH net-next v5 3/6] net: xilinx: axienet: Propagate device reset failure from ndo_open Suraj Gupta
2026-11-15 18:31 ` sashiko-bot
2026-11-16 4:12 ` netdev-bot+sashiko
2026-11-14 18:29 ` [PATCH net-next v5 4/6] net: xilinx: axienet: Add 10G/25G (XXV) ethernet support Suraj Gupta
2026-11-15 18:31 ` sashiko-bot
2026-11-16 4:12 ` netdev-bot+sashiko
2026-11-14 18:29 ` [PATCH net-next v5 5/6] net: xilinx: axienet: Dispatch statistics through axienet_config ops Suraj Gupta
2026-11-14 18:29 ` [PATCH net-next v5 6/6] net: xilinx: axienet: Add statistics support for XXV ethernet Suraj Gupta
2026-11-15 18:31 ` sashiko-bot
2026-11-16 4:12 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215720@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=suraj.gupta2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.