All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Venkat Yadlapati" <venkat.yadlapati@yahoo.com>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: Add Molokai TLMM
Date: Sun, 15 Nov 2026 20:25:14 +0000	[thread overview]
Message-ID: <sashiko-outbox-215791@kernel.org> (raw)
In-Reply-To: <20261116-molokai-tlmm-v1-1-3ba4840002cb@yahoo.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: pinctrl: qcom: inconsistent indentation in
  molokai-tlmm example
--

commit 422a3a1a2e538d8b4b4ceddc48ac192080f17ae8
Author: Venkat Yadlapati <venkat.yadlapati@yahoo.com>

dt-bindings: pinctrl: qcom: Add Molokai TLMM

This commit adds the Device Tree binding schema for the Top Level Mode
Multiplexer (TLMM) pin controller on the Qualcomm Molokai (SM8845) SoC.

> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,molokai-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,molokai-tlmm.yaml
> new file mode 100644
> index 0000000000000..9196902e37d6e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,molokai-tlmm.yaml
[ ... ]
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    tlmm: pinctrl@f100000 {
> +        compatible = "qcom,molokai-tlmm";
> +        reg = <0x0f100000 0x300000>;
> +        interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> +        gpio-controller;
> +        #gpio-cells = <2>;
> +        gpio-ranges = <&tlmm 0 0 206>;
> +        interrupt-controller;
> +        #interrupt-cells = <2>;
> +
> +        qup-spi4-state {
> +          pins = "gpio48", "gpio49", "gpio50", "gpio51";
> +          function = "qup1_se4";
> +        };
> +    };

[Severity: Low]
Should the properties inside qup-spi4-state be indented by 4 spaces
relative to the child node instead of 2?  Mixing 4-space and 2-space
indentation in the example triggers an indent-consistent warning from
scripts/dtc/dt-check-style.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-molokai-tlmm-v1-0-3ba4840002cb@yahoo.com?part=1

  reply	other threads:[~2026-11-15 20:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 20:19 [PATCH 0/2] pinctrl: qcom: Add the Molokai TLMM Venkat Yadlapati via B4 Relay
2026-11-15 20:19 ` Venkat Yadlapati
2026-11-15 20:19 ` [PATCH 1/2] dt-bindings: pinctrl: qcom: Add " Venkat Yadlapati via B4 Relay
2026-11-15 20:19   ` Venkat Yadlapati
2026-11-15 20:25   ` sashiko-bot [this message]
2026-11-15 20:19 ` [PATCH 2/2] pinctrl: qcom: Add Molokai TLMM driver Venkat Yadlapati via B4 Relay
2026-11-15 20:19   ` Venkat Yadlapati
2026-11-15 20:34   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-215791@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=venkat.yadlapati@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.