All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Venkat Yadlapati" <venkat.yadlapati@yahoo.com>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: Add NXP TFA9865 amplifier
Date: Sun, 15 Nov 2026 20:34:25 +0000	[thread overview]
Message-ID: <sashiko-outbox-215837@kernel.org> (raw)
In-Reply-To: <20261116-vantage-tfa9865-v1-1-e88f0dccc427@yahoo.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: dt-bindings: redundant sound-name-prefix in
  nxp,tfa9865.yaml
--

commit cf7a1e88df6af54e01055454b9dbda2662c5f8d6
Author: Venkat Yadlapati <venkat.yadlapati@yahoo.com>

ASoC: dt-bindings: Add NXP TFA9865 amplifier

This commit adds the Devicetree binding schema and MAINTAINERS entry for
the NXP TFA9865 mono class-D speaker amplifier.

> diff --git a/Documentation/devicetree/bindings/sound/nxp,tfa9865.yaml b/Documentation/devicetree/bindings/sound/nxp,tfa9865.yaml
> new file mode 100644
> index 0000000000000..955e25abe7494
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nxp,tfa9865.yaml
> @@ -0,0 +1,65 @@

[ ... ]

> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: nxp,tfa9865
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +  vddd-supply:
> +    description: Digital supply (1.8 V)
> +
> +  '#sound-dai-cells':
> +    const: 0
> +
> +  sound-name-prefix: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - '#sound-dai-cells'
> +
> +unevaluatedProperties: false

[Severity: Low]
Is sound-name-prefix: true needed here?  dai-common.yaml# references
component-common.yaml#, which already defines sound-name-prefix, and
unevaluatedProperties: false permits properties from referenced allOf
schemas without re-listing them when no extra constraints are added.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-vantage-tfa9865-v1-0-e88f0dccc427@yahoo.com?part=1

  reply	other threads:[~2026-11-15 20:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 20:20 [PATCH 0/2] ASoC: Add the NXP TFA9865 amplifier Venkat Yadlapati
2026-11-15 20:20 ` Venkat Yadlapati via B4 Relay
2026-11-15 20:20 ` [PATCH 1/2] ASoC: dt-bindings: Add " Venkat Yadlapati
2026-11-15 20:20   ` Venkat Yadlapati via B4 Relay
2026-11-15 20:34   ` sashiko-bot [this message]
2026-11-15 20:20 ` [PATCH 2/2] ASoC: codecs: Add NXP TFA9865 amplifier driver Venkat Yadlapati
2026-11-15 20:20   ` Venkat Yadlapati via B4 Relay
2026-11-15 20:44   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-215837@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=venkat.yadlapati@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.