From: sashiko-bot@kernel.org
To: "Julius Bairaktaris" <julius@bairaktaris.de>,
linux-hyperv@vger.kernel.org
Subject: Re: [PATCH net] hv_netvsc: fall back to one queue when a sub channel fails to open
Date: Sun, 15 Nov 2026 22:04:05 +0000 [thread overview]
Message-ID: <sashiko-outbox-215875@kernel.org> (raw)
In-Reply-To: <20261114220358.5429-1-julius@bairaktaris.de>
Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [High] hv_netvsc: UAF and primary-channel false match in
rndis_subchannel_opened()
- [Medium] hv_netvsc: clamping max_chn to 1 on fallback blocks ethtool
-L recovery
- [Medium] hv_netvsc: stale multi-queue rx_table after
rndis_set_subchannel() fallback
It also noticed 1 related pre-existing issue this patch does not
introduce:
- [High] Drivers: hv: vmbus: skipped sub-channel callback in
vmbus_add_channel_work() [1]
--
commit 616fd3140681fc7618c2c8a9fe6e8fd4a476a8d1
Author: Julius Bairaktaris <julius@bairaktaris.de>
hv_netvsc: fall back to one queue when a sub channel fails to open
This commit checks whether all VMBus sub-channels opened during
rndis_set_subchannel() and falls back to a single queue, disabling and
deleting sub-channel NAPIs, if any sub-channel failed to open.
Link: https://github.com/microsoft/WSL/issues/41622
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 1d43c73fd73f1..ffa5999dc576c 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -1023,7 +1023,7 @@ static int netvsc_attach(struct net_device *ndev,
> struct netvsc_device *nvdev;
> struct rndis_device *rdev;
> struct bpf_prog *prog;
> - int ret = 0;
> + int i, ret = 0;
>
> nvdev = rndis_filter_device_add(hdev, dev_info);
> if (IS_ERR(nvdev))
> @@ -1034,8 +1034,13 @@ static int netvsc_attach(struct net_device *ndev,
>
> /* if unavailable, just proceed with one queue */
> if (ret) {
> + for (i = 1; i < nvdev->num_chn; i++)
> + netif_napi_del(&nvdev->chan_table[i].napi);
> +
> nvdev->max_chn = 1;
> nvdev->num_chn = 1;
> + netif_set_real_num_tx_queues(ndev, 1);
> + netif_set_real_num_rx_queues(ndev, 1);
> }
> }
[Severity: Medium]
Does keeping nvdev->max_chn = 1 here and in netvsc_subchan_work() prevent
raising the channel count back above 1 with ethtool -L after a fallback,
contrary to the commit message?
netvsc_get_channels() reports nvdev->max_chn as channel->max_combined, and
both ethnl_set_channels() and netvsc_set_channels() reject any requested
channel count greater than max_chn with -EINVAL unless another full
reattach (such as an MTU change) happens first to recompute max_chn in
rndis_filter_device_add().
> diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
> index 9622513275069..fe5acce0bb06b 100644
> --- a/drivers/net/hyperv/rndis_filter.c
> +++ b/drivers/net/hyperv/rndis_filter.c
> @@ -1278,6 +1278,31 @@ static void netvsc_sc_open(struct vmbus_channel *new_sc)
> wake_up(&nvscdev->subchan_open);
> }
>
> +static bool rndis_subchannel_opened(struct netvsc_device *nvdev, int i)
> +{
> + struct vmbus_channel *chn = nvdev->chan_table[i].channel;
> +
> + return chn && chn->state == CHANNEL_OPENED_STATE;
> +}
[Severity: High]
Can rndis_subchannel_opened() dereference a freed vmbus_channel or falsely
match the primary channel?
netvsc_sc_open() assigns nvchan->channel = new_sc before calling
vmbus_open(), and leaves it set if vmbus_open() fails (leaving new_sc in
CHANNEL_OPEN_STATE). If that sub-channel is rescinded,
vmbus_onoffer_rescind() sees CHANNEL_OPEN_STATE and immediately frees the
channel once probe_done is set:
CPU0 CPU1
rndis_set_subchannel() vmbus_add_channel_work()
wait_event(nvdev->subchan_open, ...) netvsc_sc_open()
nvchan->channel = new_sc
vmbus_open(new_sc) -> fails
atomic_inc_return(&open_chn)
newchannel->probe_done = true
vmbus_onoffer_rescind()
hv_process_channel_removal()
...
kfree_rcu(channel, rcu)
rndis_subchannel_opened()
chn->state <-- use-after-free
In addition, netvsc_device_add() initializes every
nvdev->chan_table[i].channel slot to the primary channel (device->channel),
which is in CHANNEL_OPENED_STATE. If any slot was not overwritten by
netvsc_sc_open(), rndis_subchannel_opened() returns true for the primary
channel and rndis_disable_subchannels() hangs in napi_disable() on a
sub-channel NAPI that was never enabled.
Clearing nvchan->channel = NULL when vmbus_open() fails in
netvsc_sc_open() and checking is_sub_channel(chn) would avoid both issues.
> +
> +/* Disable the NAPI of the sub channels that opened. netvsc_sc_open()
> + * already disabled it on the others.
> + */
> +static void rndis_disable_subchannels(struct net_device *ndev,
> + struct netvsc_device *nvdev)
> +{
> + int i;
> +
> + for (i = 1; i < nvdev->num_chn; i++) {
> + if (!rndis_subchannel_opened(nvdev, i))
> + continue;
> +
> + netif_queue_set_napi(ndev, i, NETDEV_QUEUE_TYPE_TX, NULL);
> + netif_queue_set_napi(ndev, i, NETDEV_QUEUE_TYPE_RX, NULL);
> + napi_disable(&nvdev->chan_table[i].napi);
> + }
> +}
[Severity: Medium]
When falling back to one queue here, does ndc->rx_table retain the
multi-queue indices populated earlier by rndis_filter_device_add()?
Because ndc->rx_table is not reset to queue 0 and the opened sub-channels
remain in CHANNEL_OPENED_STATE, ethtool -x reports nonexistent queue
indices, and updating the RSS hash key via ethtool -X (netvsc_set_rxfh()
with rxfh->indir == NULL) sends that multi-queue indirection table to the
host via rndis_filter_set_rss_param(), steering RX traffic onto
sub-channels whose NAPIs have been disabled and deleted.
> @@ -1329,6 +1354,19 @@ int rndis_set_subchannel(struct net_device *ndev,
> wait_event(nvdev->subchan_open,
> atomic_read(&nvdev->open_chn) == nvdev->num_chn);
[Severity: High]
This problem wasn't introduced by this patch, but can wait_event() on
nvdev->subchan_open hang forever under rtnl_lock if
vmbus_add_channel_kobj() fails in vmbus_add_channel_work() [1]?
drivers/hv/channel_mgmt.c:vmbus_add_channel_work() {
if (primary_channel != NULL) {
/* newchannel is a sub-channel. */
struct hv_device *dev = primary_channel->device_obj;
if (vmbus_add_channel_kobj(dev, newchannel))
goto err_deq_chan;
if (primary_channel->sc_creation_callback != NULL)
primary_channel->sc_creation_callback(newchannel);
}
When vmbus_add_channel_kobj() fails for a sub-channel offer, jumping to
err_deq_chan skips sc_creation_callback (netvsc_sc_open()), so
nvdev->open_chn is never incremented to nvdev->num_chn and
rndis_set_subchannel() sleeps indefinitely while holding rtnl_lock.
[1] https://sashiko.dev/#/bug/linux-83f4f08e-02b2-4a16-8ce7-6803e9b794d6
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261114220358.5429-1-julius@bairaktaris.de?part=1
next prev parent reply other threads:[~2026-11-15 22:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 22:03 [PATCH net] hv_netvsc: fall back to one queue when a sub channel fails to open Julius Bairaktaris
2026-11-15 22:04 ` sashiko-bot [this message]
2026-11-16 2:10 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215875@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=julius@bairaktaris.de \
--cc=linux-hyperv@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.