From: sashiko-bot@kernel.org
To: "Adolfo Morales Tena" <spidermanadolfo@gmail.com>,
linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: amd: yc: Add DMI quirk for GIGABYTE EAGLE 9MJ
Date: Sun, 15 Nov 2026 23:34:49 +0000 [thread overview]
Message-ID: <sashiko-outbox-215904@kernel.org> (raw)
In-Reply-To: <20261115232942.5820-1-spidermanadolfo@gmail.com>
Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [High] ASoC: amd: yc: bypassed AcpDmicConnected check in acp6x_probe()
[1]
--
commit e897ced0b25eb47667a9260d248834825a1643ca
Author: Adolfo Morales Tena <spidermanadolfo@gmail.com>
ASoC: amd: yc: Add DMI quirk for GIGABYTE EAGLE 9MJ
This commit adds a DMI quirk entry for the GIGABYTE EAGLE 9MJ to
yc_acp_quirk_table to enable internal DMIC support.
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index e14c73e7e988a..f636b5ba5b072 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -969,6 +969,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "TUF Gaming A16 FA607NUQ"),
> }
> },
> + {
> + .driver_data = &acp6x_card,
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "GIGABYTE"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "GIGABYTE EAGLE 9MJ"),
> + }
> + },
> {}
> };
[Severity: High]
This problem wasn't introduced by this patch, but does acp6x_probe()
bypass the is_dmic_enable check when the _WOV ACPI method is missing
[1]?
sound/soc/amd/yc/acp6x-mach.c:acp6x_probe() {
...
ret = acpi_evaluate_integer(handle, "_WOV", NULL, &dmic_status);
if (!ACPI_FAILURE(ret)) {
wov_en = dmic_status;
if (!wov_en)
goto check_dmi_entry;
} else {
/* Incase of ACPI method read failure then jump to check_dmi_entry */
goto check_dmi_entry;
}
if (is_dmic_enable)
platform_set_drvdata(pdev, &acp6x_card);
check_dmi_entry:
/* check for any DMI overrides */
dmi_id = dmi_first_match(yc_acp_quirk_table);
...
}
When a BIOS sets the AcpDmicConnected _DSD property to 1 (setting
is_dmic_enable = true) but omits the _WOV method, acpi_evaluate_integer()
fails and the else branch jumps directly to check_dmi_entry. That skips
binding acp6x_card from is_dmic_enable, so unless the machine is also
listed in yc_acp_quirk_table, platform_get_drvdata() returns NULL and
acp6x_probe() fails with -ENODEV.
[1] https://sashiko.dev/#/bug/linux-9da65c71-a54c-4d66-b1a8-325c916b74d6
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261115232942.5820-1-spidermanadolfo@gmail.com?part=1
next prev parent reply other threads:[~2026-11-15 23:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 23:29 [PATCH] ASoC: amd: yc: Add DMI quirk for GIGABYTE EAGLE 9MJ Adolfo Morales Tena
2026-11-15 23:34 ` sashiko-bot [this message]
2026-11-16 2:55 ` Mukunda,Vijendar
2026-11-17 12:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215904@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=spidermanadolfo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.