From: sashiko-bot@kernel.org
Cc: linux-security-module@vger.kernel.org
Subject: Re: [PATCH v3 4/5] tpm2-sessions: Re-orchestrate tpm2_read_public() use
Date: Mon, 16 Nov 2026 00:58:49 +0000 [thread overview]
Message-ID: <sashiko-outbox-215981@kernel.org> (raw)
In-Reply-To: <20261116005105.1573016-5-jarkko@kernel.org>
> Move TPM handle name resolution out of tpm_buf_append_name(), so that
> callers resolve object names explicitly before constructing HMAC-protected
> commands:
>
> 1. Export tpm2_read_public(), so that trusted_tpm2 can resolve handle
> names, and store non-object handles in big-endian byte order matching
> the TPM 2.0 handle Name definition.
> 2. Call tpm2_read_public() explicitly in tpm2_seal_trusted(),
> tpm2_load_cmd(), and tpm2_unseal_cmd() before starting the auth
> session, and pass the pre-resolved name and size to
> tpm_buf_append_name().
> 3. Rework tpm_buf_append_name() and tpm_buf_fill_hmac_session() to use
> the caller-supplied name and size directly.
>
> This reduces fallible exits from tpm2_buf_append_name().
>
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116005105.1573016-1-jarkko@kernel.org?part=4
next prev parent reply other threads:[~2026-11-16 0:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 0:50 [PATCH v3 0/5] Unsorted tpm2-sessions improvements Jarkko Sakkinen
2026-11-16 0:51 ` [PATCH v3 1/5] tpm2-sessions: Drop TPM2_NAME_SIZE Jarkko Sakkinen
2026-11-16 0:55 ` sashiko-bot
2026-11-16 9:43 ` Jonathan McDowell
2026-11-16 9:53 ` Jarkko Sakkinen
2026-11-16 0:51 ` [PATCH v3 2/5] KEYS: trusted: Open code tpm2_buf_append_auth() Jarkko Sakkinen
2026-11-16 0:56 ` sashiko-bot
2026-11-16 0:51 ` [PATCH v3 3/5] KEYS: trusted: Remove dead branch from tpm2_unseal_cmd Jarkko Sakkinen
2026-11-16 0:56 ` sashiko-bot
2026-11-16 0:51 ` [PATCH v3 4/5] tpm2-sessions: Re-orchestrate tpm2_read_public() use Jarkko Sakkinen
2026-11-16 0:58 ` sashiko-bot [this message]
2026-11-16 0:51 ` [PATCH v3 5/5] tpm-buf: Make tpm_buf_read*() fallible Jarkko Sakkinen
2026-11-16 1:09 ` sashiko-bot
2026-11-16 1:29 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215981@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.