All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Bryam Vargas" <hexlabsecurity@proton.me>
Cc: linux-s390@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH RFC net v4 1/8] net/iucv: keep the window given to the peer in a field of its own
Date: Mon, 16 Nov 2026 01:29:23 +0000	[thread overview]
Message-ID: <sashiko-outbox-215992@kernel.org> (raw)
In-Reply-To: <20261114-b4-disp-fc0634a3-v4-1-f96c506447ce@proton.me>

> From: Bryam Vargas <hexlabsecurity@proton.me>
> 
> A HiperSockets SYN carries msglimit as the receive window, and
> SO_MSGLIMIT is accepted while the socket is IUCV_BOUND, which it is
> until the SYN|ACK arrives. A msglimit changed in between leaves the peer
> with the window the SYN carried, while recvmsg() counts the frames it
> reads against the new value:
> 
> - Lowered, a peer that keeps to its window has the socket closed on it
>   once the receive buffer is full and frames wait in backlog_skb_q,
>   where no window update resets the count: WARN_ON(), -EFAULT, the rest
>   of the stream lost.
> - Raised far enough, the threshold of the window update lies above the
>   window: the count never reaches it, the peer uses up its window and
>   its writer waits for an update that only a data frame from us would
>   carry.
> 
> Record the window when the first SYN of a socket leaves, and in a
> listener's SYN|ACK, and let recvmsg() count frames against it and take
> the window-update threshold from it. A SYN that is not sent records
> nothing, and a later SYN of the socket carries the recorded window. A
> msglimit set after the first SYN no longer changes anything for that
> socket; getsockopt() still returns it. A socket connected by a SYN|ACK
> without having sent a SYN keeps msglimit as its window.
> 
> Fixes: 3881ac441f64 ("af_iucv: add HiperSockets transport")
> Fixes: 800c5eb7b5eb ("af_iucv: change net_device handling for HS transport")
> Cc: stable@vger.kernel.org # 6.18.x
> Signed-off-by: Bryam Vargas <hexlabsecurity@proton.me>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114-b4-disp-fc0634a3-v4-0-f96c506447ce@proton.me?part=1


  reply	other threads:[~2026-11-16  1:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15  1:29 [PATCH RFC net v4 0/8] net/iucv: serialize the HiperSockets receive path with the socket lock Bryam Vargas via B4 Relay
2026-11-15  1:29 ` Bryam Vargas
2026-11-15  1:29 ` [PATCH RFC net v4 1/8] net/iucv: keep the window given to the peer in a field of its own Bryam Vargas via B4 Relay
2026-11-15  1:29   ` Bryam Vargas
2026-11-16  1:29   ` sashiko-bot [this message]
2026-11-15  1:29 ` [PATCH RFC net v4 2/8] net/iucv: do not clear SEND_SHUTDOWN to send a control frame Bryam Vargas via B4 Relay
2026-11-15  1:29   ` Bryam Vargas
2026-11-16  1:29   ` sashiko-bot
2026-11-15  1:29 ` [PATCH RFC net v4 3/8] net/iucv: fail sendmsg() with EPIPE once sending is shut down Bryam Vargas via B4 Relay
2026-11-15  1:29   ` Bryam Vargas
2026-11-16  1:29   ` sashiko-bot
2026-11-15  1:29 ` [PATCH RFC net v4 4/8] net/iucv: run recvmsg() under the socket lock Bryam Vargas via B4 Relay
2026-11-15  1:29   ` Bryam Vargas
2026-11-16  1:29   ` sashiko-bot
2026-11-15  1:29 ` [PATCH RFC net v4 5/8] net/iucv: factor out the HiperSockets frame dispatch and state changes Bryam Vargas via B4 Relay
2026-11-15  1:29   ` Bryam Vargas
2026-11-16  1:29   ` sashiko-bot
2026-11-15  1:29 ` [PATCH RFC net v4 6/8] net/iucv: serialize HiperSockets receive with the socket lock Bryam Vargas via B4 Relay
2026-11-15  1:29   ` Bryam Vargas
2026-11-16  1:29   ` sashiko-bot
2026-11-15  1:29 ` [PATCH RFC net v4 7/8] net/iucv: set RCV_SHUTDOWN under the socket spinlock Bryam Vargas via B4 Relay
2026-11-15  1:29   ` Bryam Vargas
2026-11-16  1:29   ` sashiko-bot
2026-11-15  1:29 ` [PATCH RFC net v4 8/8] net/iucv: return EOF to a reader parked when the peer closes Bryam Vargas via B4 Relay
2026-11-15  1:29   ` Bryam Vargas
2026-11-16  1:29   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-215992@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=hexlabsecurity@proton.me \
    --cc=linux-s390@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.