From: sashiko-bot@kernel.org
To: "Aibing Chen" <chenaibing@cmss.chinamobile.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] net: hso: cap the MTU to the mux tx buffer size
Date: Mon, 16 Nov 2026 01:58:51 +0000 [thread overview]
Message-ID: <sashiko-outbox-216041@kernel.org> (raw)
In-Reply-To: <20261116014904.556-1-chenaibing@cmss.chinamobile.com>
> hso_net_start_xmit() copies skb->len bytes into odev->mux_bulk_tx_buf,
> which is a fixed MUX_BULK_TX_BUF_SIZE (2048) allocation made by
> hso_create_net_device(). The net device does not set max_mtu, so
> userspace can raise the MTU up to IP_MAX_MTU and make that copy overflow
> the buffer; the same length is passed to usb_fill_bulk_urb().
>
> Cap the MTU at the buffer size, keeping the 14 byte allowance that the
> default MTU already uses.
>
> Fixes: 72dc1c096c70 ("HSO: add option hso driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Aibing Chen <chenaibing@cmss.chinamobile.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116014904.556-1-chenaibing@cmss.chinamobile.com?part=1
prev parent reply other threads:[~2026-11-16 1:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 1:49 [PATCH] net: hso: cap the MTU to the mux tx buffer size Aibing Chen
2026-11-16 1:53 ` netdev-bot+sinfo
2026-11-16 2:58 ` Aibing Chen
2026-11-16 1:58 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216041@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=chenaibing@cmss.chinamobile.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.