From: sashiko-bot@kernel.org
To: Nordschamane <nordschamane1@proton.me>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH RFC v4] ALSA: pci: add analog support for ESI MAYA44e
Date: Mon, 16 Nov 2026 04:25:27 +0000 [thread overview]
Message-ID: <sashiko-outbox-216179@kernel.org> (raw)
In-Reply-To: <20261116-codex-alsa-maya44e-v4-1-381358afc43a@proton.me>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] ALSA: maya44e: single-word handle used in Signed-off-by and
MODULE_AUTHOR
--
commit cdb85b2813a3b897c6265642a04fc30216441982
Author: Nordschamane <nordschamane1@proton.me>
> ALSA: pci: add analog support for ESI MAYA44e
>
> Add four-channel analog playback and capture for the ESI MAYA44e PCIe
> card (19fe:7000, subsystem 0e51:0001). Playback and capture share the
> sample clock and can use independent period sizes. Expose analog source,
> gain, direct monitoring, DAC and crossmix controls.
>
> The playback DMA rings and ALSA staging buffer are cleared during the
> reset that completes prepare. This keeps clearing and pointer rebasing
> under the same PCM stream lock, including for linked streams.
> Both streams use the locked reset path. A linked PREPARE holds the
> peer's buffer mutex but does not block its ALSA read or write copies.
> Take a driver buffer-access gate before touching either stream's
> buffers, and keep it until the reset callback. The stream lock then
> covers the remaining pointer rebase. Return -EBUSY if a copy is active.
> Explicit RESET takes its own gate when no prepare is in progress.
>
> Treat unavailable MMIO as an error during DMA setup, start and
> position tracking. A failed read must not be interpreted as a running
> engine or a completed capture period. After confirmed loss of access,
> skip BAR operations and use PCI configuration space for best-effort
> shutdown.
>
> Publish capture samples and the copied position under the same lock.
> Use the DMA position and elapsed time to detect missed capture periods.
> Skip early or repeated interrupts and report a capture XRUN when the
> ring may have wrapped without the driver copying the preceding half.
>
> The ES7010L register sequence comes from observed PCI transactions and
> analysis of the ESI Windows driver. The existing ALSA PCI MAYA44 driver
> was a reference for the WM8776 command format.
>
> OpenAI Codex assisted with PCI trace analysis, driver implementation,
> test tooling and the changelog. The requests covered analog playback,
> capture, mixer controls and suspend/resume.
>
> Signed-off-by: Nordschamane <nordschamane1@proton.me>
[Severity: High]
Could a real full name be used instead of the single-word handle
Nordschamane in the commit Author header, Signed-off-by trailer, and
MODULE_AUTHOR("Nordschamane") in sound/pci/maya44e.c? Under
Documentation/process/submitting-patches.rst, Developer Certificate of
Origin sign-offs and module authorship require a known real name rather
than a handle or nickname.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-codex-alsa-maya44e-v4-1-381358afc43a@proton.me?part=1
next prev parent reply other threads:[~2026-11-16 4:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 4:11 [PATCH RFC v4] ALSA: pci: add analog support for ESI MAYA44e Nordschamane
2026-11-16 4:11 ` Nordschamane via B4 Relay
2026-11-16 4:25 ` sashiko-bot [this message]
2026-11-16 15:39 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216179@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nordschamane1@proton.me \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.