All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Sreeshankar K" <sreeshankar0910@gmail.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v15 3/8] thermal/qcom/lmh: Switch to match data for SoC CPU-to-node mappings
Date: Mon, 16 Nov 2026 05:43:39 +0000	[thread overview]
Message-ID: <sashiko-outbox-216223@kernel.org> (raw)
In-Reply-To: <20261116-sm7250-v15-3-6acbb232fef8@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] thermal/qcom/lmh: commit message struct names mismatch
  lmh_soc_data
--

commit eec53390ca0e7b9b5a048e799d6259ee4ce6ec2a
Author: Sreeshankar K <sreeshankar0910@gmail.com>

thermal/qcom/lmh: Switch to match data for SoC CPU-to-node mappings

This commit replaces the hardcoded CPU-to-node ID checks in lmh_probe()
with per-SoC mapping tables stored in the OF match data.

> diff --git a/drivers/thermal/qcom/lmh.c b/drivers/thermal/qcom/lmh.c
> index 6bfe25021e05f..9d66d75d87735 100644
> --- a/drivers/thermal/qcom/lmh.c
> +++ b/drivers/thermal/qcom/lmh.c
> @@ -94,19 +94,53 @@ static const struct irq_domain_ops lmh_irq_ops = {
>  	.xlate = irq_domain_xlate_onecell,
>  };
>  
> +struct lmh_soc_map {
> +	int cpu_id;
> +	u32 node_id;
> +};
> +
> +struct lmh_soc_data {
> +	uintptr_t flags;
> +	const struct lmh_soc_map *map;
> +	size_t num_nodes;
> +};

[Severity: Low]
This isn't a bug, but the commit message refers to these structures as
struct qcom_lmh_node_map and struct qcom_lmh_soc_data instead of struct
lmh_soc_map and struct lmh_soc_data.  Also, should flags be unsigned int
instead of uintptr_t, since it is no longer cast from the match data
pointer and is assigned to unsigned int enable_alg in lmh_probe()?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-sm7250-v15-0-6acbb232fef8@gmail.com?part=3

  reply	other threads:[~2026-11-16  5:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  5:33 [PATCH v15 0/8] Add initial support for Qualcomm SM7250 SoC Sreeshankar K
2026-11-16  5:33 ` [PATCH v15 1/8] dt-bindings: clock: Add SM7250 global clock controller Sreeshankar K
2026-11-16  5:33 ` [PATCH v15 2/8] clk: qcom: Add Global Clock Controller (GCC) driver for SM7250 Sreeshankar K
2026-11-16  5:33 ` [PATCH v15 3/8] thermal/qcom/lmh: Switch to match data for SoC CPU-to-node mappings Sreeshankar K
2026-11-16  5:43   ` sashiko-bot [this message]
2026-11-16  5:33 ` [PATCH v15 4/8] dt-bindings: thermal: lmh: Document SM7250 LMh Sreeshankar K
2026-11-16  5:33 ` [PATCH v15 5/8] thermal/qcom/lmh: Add support for Qualcomm SM7250 Sreeshankar K
2026-11-16  5:33 ` [PATCH v15 6/8] dt-bindings: firmware: qcom,scm: Document SM7250 SCM Sreeshankar K
2026-11-16  5:33 ` [PATCH v15 7/8] dt-bindings: cpufreq: qcom-hw: Document SM7250 cpufreq hardware Sreeshankar K
2026-11-16  5:33 ` [PATCH v15 8/8] arm64: dts: qcom: Add SM7250 devicetree file Sreeshankar K
2026-11-16  6:16   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216223@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sreeshankar0910@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.