From: sashiko-bot@kernel.org
To: "William Chuang" <founder@logarcheon.com>, akpm@linux-foundation.org
Cc: dhowells@redhat.com, keyrings@vger.kernel.org
Subject: Re: [PATCH 1/2] lib/assoc_array: add KUnit test suite
Date: Mon, 16 Nov 2026 05:51:56 +0000 [thread overview]
Message-ID: <sashiko-outbox-216230@kernel.org> (raw)
In-Reply-To: <20261116054112.39078-2-founder@logarcheon.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] lib/assoc_array: unexported symbols break modular
ASSOC_ARRAY_KUNIT_TEST=m build
--
commit 07438606f16e23d96f51f8a13d17b392d4d4bc67
Author: William Chuang <founder@logarcheon.com>
lib/assoc_array: add KUnit test suite
This commit adds a KUnit test suite for the generic associative array in
lib/assoc_array.c, testing insertion, replacement, deletion, clearance,
iteration, and garbage collection against an expected model.
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 1dac2674a9838..157f350eee5dc 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -2856,6 +2856,23 @@ config SYSCTL_KUNIT_TEST
>
> If unsure, say N.
>
> +config ASSOC_ARRAY_KUNIT_TEST
> + tristate "KUnit test for the generic associative array" if !KUNIT_ALL_TESTS
> + depends on KUNIT
> + select ASSOCIATIVE_ARRAY
> + default KUNIT_ALL_TESTS
[Severity: Medium]
Does building with CONFIG_ASSOC_ARRAY_KUNIT_TEST=m (such as under
allmodconfig) fail at modpost?
CONFIG_ASSOCIATIVE_ARRAY is a bool option that compiles lib/assoc_array.o
into vmlinux, and lib/assoc_array.c does not export any of the
assoc_array_*() functions with EXPORT_SYMBOL(). Either
ASSOC_ARRAY_KUNIT_TEST needs to be bool with "depends on KUNIT=y", or the
assoc_array_*() functions need to be exported.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116054112.39078-1-founder@logarcheon.com?part=1
next prev parent reply other threads:[~2026-11-16 5:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 5:41 [PATCH 0/2] lib/assoc_array: fix root-shortcut split lookup regression, add KUnit tests William Chuang
2026-11-16 5:41 ` [PATCH 1/2] lib/assoc_array: add KUnit test suite William Chuang
2026-11-16 5:51 ` sashiko-bot [this message]
2026-11-16 20:28 ` kernel test robot
2026-11-16 5:41 ` [PATCH 2/2] lib/assoc_array: fix lookups after splitting a root shortcut William Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216230@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=founder@logarcheon.com \
--cc=keyrings@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.