From: sashiko-bot@kernel.org
To: "William A. Kennington III" <william@wkennington.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] usb: ehci: skip companion handoff when no companion exists
Date: Mon, 16 Nov 2026 06:41:47 +0000 [thread overview]
Message-ID: <sashiko-outbox-216297@kernel.org> (raw)
In-Reply-To: <20261116063104.1018358-1-william@wkennington.com>
> EHCI controllers without an integrated root-hub transaction translator
> unconditionally set PORT_OWNER whenever a root port sees low-speed line
> state before reset, finishes reset without enabling High-Speed mode, or
> is relinquished by usbcore after enumeration fails. When no companion
> controller is present or enabled, setting PORT_OWNER routes the port
> away from EHCI to a nonexistent or disabled controller. A single missed
> High-Speed chirp or transient D+/D- bounce during reset then strands
> downstream USB 2.0 hubs until EHCI is rebound, and connecting a USB 1.1
> device leaves the port dead to later USB 2.0 devices.
>
> Check during ehci_setup() whether the root hub has an integrated
> transaction translator (ehci_is_TDI()), HCSPARAMS reports zero
> companions (HCS_N_CC == 0), both CONFIG_USB_OHCI_HCD and
> CONFIG_USB_UHCI_HCD are disabled in Kconfig (such as in
> aspeed_g4_defconfig, aspeed_g5_defconfig, and BMC builds without UHCI
> or OHCI), or a Device Tree companion phandle points to a disabled node.
> Runtime companion binding is intentionally not checked at setup time so
> modular or later-probing companion drivers still receive handoffs.
>
> When no companion is available, set ehci->no_companion so the handoff
> and companion sysfs paths check a single flag, keeping port ownership
> on EHCI when no companion exists. USB 1.1 full- and low-speed devices
> still cannot enumerate without an integrated TT or companion controller
> and will fail usbcore's normal reset retries instead of triggering a
> PORT_OWNER handoff.
>
> Signed-off-by: William A. Kennington III <william@wkennington.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116063104.1018358-1-william@wkennington.com?part=1
next prev parent reply other threads:[~2026-11-16 6:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 6:31 [PATCH v2] usb: ehci: skip companion handoff when no companion exists William A. Kennington III
2026-11-16 6:41 ` sashiko-bot [this message]
2026-11-16 18:31 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216297@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=william@wkennington.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.