All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Andrew Gaylard" <ag@ffroot.co.za>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] phy: sunplus: don't read the disc_vol cell after nvmem_cell_get() fails
Date: Mon, 16 Nov 2026 07:49:01 +0000	[thread overview]
Message-ID: <sashiko-outbox-216467@kernel.org> (raw)
In-Reply-To: <20261116074006.20357-1-ag@ffroot.co.za>

> update_disc_vol() returns early only when nvmem_cell_get() gives
> -EPROBE_DEFER. On any other error, such as -ENOENT for a device tree
> without a disc_vol cell, it passes the error pointer to
> nvmem_cell_read() and nvmem_cell_put(), which dereference it.
> 
> Use the default disconnect-voltage level on these errors, as the function
> already does when the read fails. nvmem_cell_get() never returns NULL,
> so IS_ERR() is enough.
> 
> Tested on a Tibbo LTPP3G2 board.
> 
> Fixes: 99d9ccd97385 ("phy: usb: Add USB2.0 phy driver for Sunplus SP7021")
> Signed-off-by: Andrew Gaylard <ag@ffroot.co.za>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116074006.20357-1-ag@ffroot.co.za?part=1


      parent reply	other threads:[~2026-11-16  7:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  7:40 [PATCH 1/2] phy: sunplus: don't read the disc_vol cell after nvmem_cell_get() fails Andrew Gaylard
2026-11-16  7:40 ` Andrew Gaylard
2026-11-16  7:40 ` [PATCH 2/2] phy: sunplus: free the disc_vol buffer in update_disc_vol() Andrew Gaylard
2026-11-16  7:40   ` Andrew Gaylard
2026-11-16  7:46   ` sashiko-bot
2026-11-16  7:49 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216467@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=ag@ffroot.co.za \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.