From: sashiko-bot@kernel.org
To: "Ankur Arora" <ankur.a.arora@oracle.com>, bpf@vger.kernel.org
Subject: Re: [PATCH v17 07/16] atomic: Add atomic_cond_read_*_timeout()
Date: Mon, 16 Nov 2026 08:49:18 +0000 [thread overview]
Message-ID: <sashiko-outbox-216566@kernel.org> (raw)
In-Reply-To: <20261116082437.66739-8-ankur.a.arora@oracle.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] Documentation/atomic_t: inaccurate non-atomic_t and conditional
store text
--
commit d324a5d412956ca2cd74e953ba1e9d33ac409b28
Author: Ankur Arora <ankur.a.arora@oracle.com>
atomic: Add atomic_cond_read_*_timeout()
This commit adds atomic_cond_read_{acquire,relaxed}_timeout() and
atomic64_cond_read_{acquire,relaxed}_timeout() wrappers around the
smp_cond_load_*_timeout() helpers, and documents the conditional read
interfaces in Documentation/atomic_t.txt.
> diff --git a/Documentation/atomic_t.txt b/Documentation/atomic_t.txt
> index bee3b1bca9a7b..0e53f6ccb5580 100644
> --- a/Documentation/atomic_t.txt
> +++ b/Documentation/atomic_t.txt
> @@ -16,6 +16,10 @@ Non-RMW ops:
> atomic_read(), atomic_set()
> atomic_read_acquire(), atomic_set_release()
>
> +Non-RMW, non-atomic_t ops:
> +
> + atomic_cond_read_{relaxed,acquire}()
> + atomic_cond_read_{relaxed,acquire}_timeout()
>
> RMW atomic operations:
>
> @@ -79,11 +83,11 @@ SEMANTICS
>
> Non-RMW ops:
>
> -The non-RMW ops are (typically) regular LOADs and STOREs and are canonically
> -implemented using READ_ONCE(), WRITE_ONCE(), smp_load_acquire() and
> -smp_store_release() respectively. Therefore, if you find yourself only using
> -the Non-RMW operations of atomic_t, you do not in fact need atomic_t at all
> -and are doing it wrong.
> +The non-RMW ops are (typically) regular, or conditional LOADs and STOREs and
> +are canonically implemented using READ_ONCE(), WRITE_ONCE(),
> +smp_load_acquire() and smp_store_release() respectively. Therefore, if you
> +find yourself only using the Non-RMW operations of atomic_t, you do not in
> +fact need atomic_t at all and are doing it wrong.
[Severity: Low]
Are these two documentation updates accurate?
First, atomic_cond_read_{relaxed,acquire}() and
atomic_cond_read_{relaxed,acquire}_timeout() take an atomic_t pointer and
dereference &(v)->counter, so labeling them "non-atomic_t ops" seems
misleading (the underlying non-atomic_t primitives are
smp_cond_load_{relaxed,acquire}() and
smp_cond_load_{relaxed,acquire}_timeout()).
Second, in the semantics paragraph, there are no conditional non-RMW store
operations, and inserting "or conditional" breaks the "respectively" mapping
between the four regular non-RMW operations and READ_ONCE(), WRITE_ONCE(),
smp_load_acquire(), and smp_store_release() while omitting
smp_cond_load_*().
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116082437.66739-1-ankur.a.arora@oracle.com?part=7
next prev parent reply other threads:[~2026-11-16 8:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 8:24 [PATCH v17 00/16] barrier: Add smp_cond_load_{relaxed,acquire}_timeout() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 01/16] asm-generic: barrier: Add smp_cond_load_relaxed_timeout() Ankur Arora
2026-11-16 8:42 ` sashiko-bot
2026-11-17 5:30 ` Ankur Arora
2026-11-16 8:24 ` [PATCH v17 02/16] arm64: barrier: Support smp_cond_load_relaxed_timeout() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 03/16] arm64/delay: define arm64_wfet_deadline() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 04/16] arm64: support WFET in smp_cond_load_relaxed_timeout() Ankur Arora
2026-11-16 8:46 ` sashiko-bot
2026-11-17 5:23 ` Ankur Arora
2026-11-16 8:24 ` [PATCH v17 05/16] arm64: rqspinlock: Remove private copy of smp_cond_load_acquire_timewait() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 06/16] asm-generic: barrier: Add smp_cond_load_acquire_timeout() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 07/16] atomic: Add atomic_cond_read_*_timeout() Ankur Arora
2026-11-16 8:49 ` sashiko-bot [this message]
2026-11-16 8:24 ` [PATCH v17 08/16] locking/atomic: scripts: build atomic_long_cond_read_*_timeout() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 09/16] bpf/rqspinlock: switch check_timeout() to a clock interface Ankur Arora
2026-11-16 8:24 ` [PATCH v17 10/16] bpf/rqspinlock: Use smp_cond_load_acquire_timeout() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 11/16] sched: add need-resched timed wait interface Ankur Arora
2026-11-16 8:24 ` [PATCH v17 12/16] cpuidle/poll_state: Wait for need-resched via tif_need_resched_relaxed_wait() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 13/16] arm64/delay: enable testing smp_cond_load_relaxed_timeout() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 14/16] barrier: add tests for smp_cond_load_*_timeout() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 15/16] barrier: timeout validity checks for smp_cond_load_relaxed_timeout() Ankur Arora
2026-11-16 8:45 ` sashiko-bot
2026-11-17 5:26 ` Ankur Arora
2026-11-16 8:24 ` [PATCH v17 16/16] barrier: timeout validity checks for smp_cond_load_acquire_timeout() Ankur Arora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216566@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ankur.a.arora@oracle.com \
--cc=bpf@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.