All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Kuldeep Singh" <kuldeep.singh@oss.qualcomm.com>,
	"Bartosz Golaszewski" <brgl@kernel.org>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Abel Vesa" <abelvesa@kernel.org>
Cc: "Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>,
	linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
	"Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
	"Wenjia Zhang" <wenjia.zhang@oss.qualcomm.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: shikra: Correct QCE node configuration
Date: Mon, 16 Nov 2026 09:26:03 +0000	[thread overview]
Message-ID: <sashiko-outbox-216611@kernel.org> (raw)
In-Reply-To: <20261116-shikra_qce_fix-v3-2-9ae31470ef48@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: shikra: removal of QCE memory interconnect
  path
--

commit dd0d4eb9c6460c2234e0ce40f58aef857431e597
Author: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>

arm64: dts: qcom: shikra: Correct QCE node configuration

This commit updates the Shikra QCE node fallback compatible string to
"qcom,ipq4019-qce", adds the "core" clock, and removes the "memory"
interconnect properties.

> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
> index 0a95ad5a5582c..d5f0ef863173e 100644
> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
> @@ -1208,7 +1208,7 @@ cryptobam: dma-controller@1b04000 {
>  		};
>  
>  		crypto: crypto@1b3a000 {
> -			compatible = "qcom,shikra-qce", "qcom,sm8150-qce", "qcom,qce";
> +			compatible = "qcom,shikra-qce", "qcom,ipq4019-qce", "qcom,qce";
>  			reg = <0x0 0x01b3a000 0x0 0x6000>;
>  			dmas = <&cryptobam 4>, <&cryptobam 5>;
>  			dma-names = "rx", "tx";
> @@ -1219,9 +1219,8 @@ crypto: crypto@1b3a000 {
>  				 <&apps_smmu 0x96 0x0011>,
>  				 <&apps_smmu 0x98 0x0001>,
>  				 <&apps_smmu 0x9f 0x0>;
> -			interconnects = <&system_noc MASTER_CRYPTO_CORE0 0
> -					 &mc_virt SLAVE_EBI_CH0 0>;
> -			interconnect-names = "memory";
> +			clocks = <&rpmcc RPM_SMD_CE1_CLK>;
> +			clock-names = "core";
>  		};
>  
>  		qfprom: efuse@1b44000 {

[Severity: Medium]
Does removing the "memory" interconnect from the crypto node leave QCE
without an interconnect bandwidth vote during crypto DMA transfers?

In drivers/firmware/qcom/qcom_scm.c, qcom_scm_bw_enable() votes on the
SCM node's interconnect path only for the duration of PAS SMC calls and
qcom_scm_bw_disable() drops that vote back to 0 as soon as each call
returns, just as it does for RPM_SMD_CE1_CLK.  Without the "memory"
interconnect property on the crypto node, devm_of_icc_get(dev, "memory")
in qce_crypto_probe() returns NULL, so qce_runtime_resume() never votes
for QCE_DEFAULT_MEM_BANDWIDTH while QCE is active.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-shikra_qce_fix-v3-0-9ae31470ef48@oss.qualcomm.com?part=2

      reply	other threads:[~2026-11-16  9:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  8:59 [PATCH v3 0/2] Shikra: Fix qce configuration Kuldeep Singh
2026-11-16  8:59 ` [PATCH v3 1/2] dt-bindings: crypto: Correct Shikra QCE compatible hierarchy Kuldeep Singh
2026-11-16  8:59 ` [PATCH v3 2/2] arm64: dts: qcom: shikra: Correct QCE node configuration Kuldeep Singh
2026-11-16  9:26   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216611@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuldeep.singh@oss.qualcomm.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=wenjia.zhang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.