From: sashiko-bot@kernel.org
To: "Matt Thompson" <matt@boondocker.io>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH RFC v3 6/6] PCI: rockchip-host: Mask the client correctable error interrupt
Date: Mon, 16 Nov 2026 09:54:35 +0000 [thread overview]
Message-ID: <sashiko-outbox-216666@kernel.org> (raw)
In-Reply-To: <20261116-rfc-b4-v3-6-0bf052b68f2a@boondocker.io>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] PCI: rockchip-host: missing Fixes trailer on bug-fix commit
--
commit f0d8b30ebd346074d58b3aee793327c70a8878bd
Author: Matt Thompson <matt@boondocker.io>
> PCI: rockchip-host: Mask the client correctable error interrupt
>
> On RockPro64 the PCIe client correctable-error bit stayed asserted
> during link bring-up despite acknowledgment. Its level interrupt
> fired at roughly one million interrupts per second on CPU 0 and
> starved RCU.
>
> Mask the controller-local notification, which the driver only uses
> for a debug message. Standard PCIe AER uses root port status and its
> separate interrupt.
>
> Signed-off-by: Matt Thompson <matt@boondocker.io>
[Severity: Low]
This fixes an interrupt storm when unmasking client interrupts in
rockchip_pcie_enable_interrupts(). Should this include:
Fixes: e77f847df54c ("PCI: rockchip: Add Rockchip PCIe controller support")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-rfc-b4-v3-0-0bf052b68f2a@boondocker.io?part=6
next prev parent reply other threads:[~2026-11-16 9:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 9:35 [PATCH RFC v3 0/6] PCI: rockchip-host: Handle unavailable downstream config space Matt Thompson
2026-11-16 9:35 ` Matt Thompson via B4 Relay
2026-11-16 9:35 ` Matt Thompson via B4 Relay
2026-11-16 9:35 ` [PATCH RFC v3 1/6] PCI: rockchip-host: Skip downstream config access while link is down Matt Thompson
2026-11-16 9:35 ` Matt Thompson via B4 Relay
2026-11-16 9:35 ` Matt Thompson via B4 Relay
2026-11-16 9:46 ` sashiko-bot
2026-11-16 9:35 ` [PATCH RFC v3 2/6] arm64: Allow synchronous abort fixups for guarded MMIO reads Matt Thompson
2026-11-16 9:35 ` Matt Thompson via B4 Relay
2026-11-16 9:35 ` Matt Thompson via B4 Relay
2026-11-16 9:47 ` sashiko-bot
2026-11-17 12:04 ` Will Deacon
2026-11-17 12:04 ` Will Deacon
2026-11-16 9:35 ` [PATCH RFC v3 3/6] PCI: rockchip-host: Recover downstream configuration access Matt Thompson
2026-11-16 9:35 ` Matt Thompson via B4 Relay
2026-11-16 9:35 ` Matt Thompson via B4 Relay
2026-11-16 9:52 ` sashiko-bot
2026-11-16 9:35 ` [PATCH RFC v3 4/6] PCI: Resume downstream ports before sysfs Link Control writes Matt Thompson
2026-11-16 9:35 ` Matt Thompson via B4 Relay
2026-11-16 9:35 ` Matt Thompson via B4 Relay
2026-11-16 10:04 ` sashiko-bot
2026-11-16 9:35 ` [PATCH RFC v3 5/6] PCI: rockchip-host: Defer retraining during initial link training Matt Thompson
2026-11-16 9:35 ` Matt Thompson via B4 Relay
2026-11-16 9:35 ` Matt Thompson via B4 Relay
2026-11-16 9:51 ` sashiko-bot
2026-11-16 9:35 ` [PATCH RFC v3 6/6] PCI: rockchip-host: Mask the client correctable error interrupt Matt Thompson
2026-11-16 9:35 ` Matt Thompson via B4 Relay
2026-11-16 9:35 ` Matt Thompson via B4 Relay
2026-11-16 9:54 ` sashiko-bot [this message]
2026-11-16 19:10 ` [PATCH RFC v3 0/6] PCI: rockchip-host: Handle unavailable downstream config space Igor Velkov
2026-11-16 19:10 ` Igor Velkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216666@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matt@boondocker.io \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.