All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Maxime Ripard" <mripard@kernel.org>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 17/64] drm/loongson: Switch to drm_mode_config_create_initial_state
Date: Mon, 16 Nov 2026 10:53:54 +0000	[thread overview]
Message-ID: <sashiko-outbox-216790@kernel.org> (raw)
In-Reply-To: <20261116-drm-no-more-config-reset-v2-17-0bb471f4d1e0@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/loongson: skipped CRTC and encoder hardware reset in
  lsdc_create_device()
--

commit 8beeb01686f101cdce0b7603e2b5e7c72cefba29
Author: Maxime Ripard <mripard@kernel.org>

drm/loongson: Switch to drm_mode_config_create_initial_state

This commit replaces drm_mode_config_reset() with
drm_mode_config_create_initial_state() during device creation in
lsdc_create_device().

> diff --git a/drivers/gpu/drm/loongson/lsdc_drv.c b/drivers/gpu/drm/loongson/lsdc_drv.c
> index 5a13df31eb902..fbb2658acce40 100644
> --- a/drivers/gpu/drm/loongson/lsdc_drv.c
> +++ b/drivers/gpu/drm/loongson/lsdc_drv.c
> @@ -247,7 +247,9 @@ lsdc_create_device(struct pci_dev *pdev,
>  	if (ret)
>  		return ERR_PTR(ret);
>  
> -	drm_mode_config_reset(ddev);
> +	ret = drm_mode_config_create_initial_state(ddev);
> +	if (ret)
> +		return ERR_PTR(ret);
>  
>  	return ldev;
>  }

[Severity: High]
Does replacing drm_mode_config_reset() with
drm_mode_config_create_initial_state() skip hardware initialization that
this driver relies on during probe?

Unlike drm_mode_config_reset(), drm_mode_config_create_initial_state() does
not call crtc->helper_private->hw_reset() or encoder->funcs->reset():

drivers/gpu/drm/loongson/lsdc_output_7a2000.c:ls7a2000_hdmi0_encoder_reset() {
	...
	val = PHY_CLOCK_POL | PHY_CLOCK_EN | PHY_DATA_EN;
	lsdc_wreg32(ldev, LSDC_CRTC0_DVO_CONF_REG, val);

	/* using software gpio emulated i2c */
	val = lsdc_rreg32(ldev, LSDC_HDMI0_INTF_CTRL_REG);
	val &= ~HW_I2C_EN;
	lsdc_wreg32(ldev, LSDC_HDMI0_INTF_CTRL_REG, val);

	/* help the hdmi phy to get out of reset state */
	lsdc_wreg32(ldev, LSDC_HDMI0_PHY_CTRL_REG, HDMI_PHY_RESET_N);
	...
}

On both LS7A1000 and LS7A2000, the encoder reset callbacks are the only
places in the driver that program LSDC_CRTC0_DVO_CONF_REG and
LSDC_CRTC1_DVO_CONF_REG.  On LS7A2000, skipping encoder reset also leaves
the HDMI PHY in reset and HW_I2C_EN set, breaking software GPIO I2C for
connector detection and EDID reads before an atomic enable runs.  In
addition, skipping lsdc_crtc_hw_reset() leaves LSDC_CRTC0_CFG_REG and
LSDC_CRTC1_CFG_REG with firmware settings across read-modify-write modeset
updates instead of initializing them to CFG_RESET_N | LSDC_PF_XRGB8888.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-drm-no-more-config-reset-v2-0-0bb471f4d1e0@kernel.org?part=17

  reply	other threads:[~2026-11-16 10:54 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 10:30 [PATCH v2 00/64] drm: Switch drivers to drm_mode_config_create_initial_state Maxime Ripard
2026-11-16 10:30 ` Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 01/64] drm/adp: Switch " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 02/64] drm/amdgpu: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 03/64] drm/hdlcd: Fix drm_atomic_helper_shutdown() on the probe error path Maxime Ripard
2026-11-16 18:10   ` Liviu Dudau
2026-11-16 10:30 ` [PATCH v2 04/64] drm/hdlcd: Switch to drm_mode_config_create_initial_state Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 05/64] drm/armada: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 06/64] drm/ast: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 07/64] drm/exynos: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 08/64] drm/fsl-dcu: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 09/64] drm/hisilicon/hibmc: Remove hibmc_unload() from the load error path Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 10/64] drm/hisilicon/hibmc: Switch to drm_mode_config_create_initial_state Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 11/64] drm/hyperv: " Maxime Ripard
2026-11-17 13:07   ` Hamza Mahfooz
2026-11-16 10:30 ` [PATCH v2 12/64] drm/imx/ipuv3: " Maxime Ripard
2026-11-16 11:40   ` Philipp Zabel
2026-11-16 10:30 ` [PATCH v2 13/64] drm/ingenic: Move the private object creation before the reset Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 14/64] drm/ingenic: Switch to drm_mode_config_create_initial_state Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 15/64] drm/kmb: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 16/64] drm/logicvc: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 17/64] drm/loongson: " Maxime Ripard
2026-11-16 10:53   ` sashiko-bot [this message]
2026-11-16 10:30 ` [PATCH v2 18/64] drm/mediatek: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 19/64] drm/mgag200: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 20/64] drm/msm: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 21/64] drm/nouveau: " Maxime Ripard
2026-11-16 10:30   ` Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 22/64] drm/omap: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 23/64] drm/qxl: Destroy the monitors object on the modeset init error path Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 24/64] drm/qxl: Switch to drm_mode_config_create_initial_state Maxime Ripard
2026-11-16 10:52   ` sashiko-bot
2026-11-16 10:30 ` [PATCH v2 25/64] drm/rcar-du: " Maxime Ripard
2026-11-17 23:53   ` Laurent Pinchart
2026-11-16 10:30 ` [PATCH v2 26/64] drm/rz-du: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 27/64] drm/shmobile: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 28/64] drm/st7571: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 29/64] drm/st7586: " Maxime Ripard
2026-11-17 14:03   ` David Lechner
2026-11-16 10:30 ` [PATCH v2 30/64] drm/st7735r: " Maxime Ripard
2026-11-17 14:03   ` David Lechner
2026-11-16 10:30 ` [PATCH v2 31/64] drm/st7920: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 32/64] drm/sprd: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 33/64] drm/sti: Fix drm_atomic_helper_shutdown() on the bind error paths Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 34/64] drm/sti: Move drm_mode_config_create_initial_state() before drm_dev_register() Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 35/64] drm/stm: Switch to drm_mode_config_create_initial_state Maxime Ripard
2026-11-16 14:50   ` Raphael Gallais-Pou
2026-11-16 10:30 ` [PATCH v2 36/64] drm/sun4i: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 37/64] drm/tegra: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 38/64] drm/tests: drm_atomic_state_test: " Maxime Ripard
2026-11-16 10:55   ` sashiko-bot
2026-11-16 10:30 ` [PATCH v2 39/64] drm/tests: drm_atomic_test: " Maxime Ripard
2026-11-16 10:53   ` sashiko-bot
2026-11-16 10:30 ` [PATCH v2 40/64] drm/tests: drm_bridge_test: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 41/64] drm/tests: drm_hdmi_state_helper_test: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 42/64] drm/tidss: " Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 43/64] drm/tilcdc: " Maxime Ripard
2026-11-16 11:10   ` sashiko-bot
2026-11-16 10:31 ` [PATCH v2 44/64] drm/arcpgu: " Maxime Ripard
2026-11-16 10:31 ` [PATCH v2 45/64] drm/bochs: " Maxime Ripard
2026-11-16 10:55   ` sashiko-bot
2026-11-16 10:31 ` [PATCH v2 46/64] drm/cirrus-qemu: " Maxime Ripard
2026-11-16 10:54   ` sashiko-bot
2026-11-16 10:31 ` [PATCH v2 47/64] drm/gm12u320: " Maxime Ripard
2026-11-16 10:31 ` [PATCH v2 48/64] drm/hx8357d: " Maxime Ripard
2026-11-16 10:31 ` [PATCH v2 49/64] drm/ili9163: " Maxime Ripard
2026-11-16 10:31 ` [PATCH v2 50/64] drm/ili9225: " Maxime Ripard
2026-11-17 14:03   ` David Lechner
2026-11-16 10:31 ` [PATCH v2 51/64] drm/ili9341: " Maxime Ripard
2026-11-16 10:31 ` [PATCH v2 52/64] drm/ili9486: " Maxime Ripard
2026-11-16 10:31 ` [PATCH v2 53/64] drm/mi0283qt: " Maxime Ripard
2026-11-16 10:31 ` [PATCH v2 54/64] drm/panel-mipi-dbi: " Maxime Ripard
2026-11-16 10:31 ` [PATCH v2 55/64] drm/pixpaper: " Maxime Ripard
2026-11-16 10:31 ` [PATCH v2 56/64] drm/repaper: " Maxime Ripard
2026-11-16 10:31 ` [PATCH v2 57/64] drm/sharp-memory: " Maxime Ripard
2026-11-16 10:31 ` [PATCH v2 58/64] drm/udl: " Maxime Ripard
2026-11-16 10:31 ` [PATCH v2 59/64] drm/vboxvideo: " Maxime Ripard
2026-11-16 10:31 ` [PATCH v2 60/64] drm/verisilicon: " Maxime Ripard
2026-11-16 10:31 ` [PATCH v2 61/64] drm/virtio: " Maxime Ripard
2026-11-16 11:01   ` sashiko-bot
2026-11-16 10:31 ` [PATCH v2 62/64] drm/vmwgfx: " Maxime Ripard
2026-11-16 11:08   ` sashiko-bot
2026-11-17  6:52   ` Zack Rusin
2026-11-16 10:31 ` [PATCH v2 63/64] drm/xen: " Maxime Ripard
2026-11-16 10:31 ` [PATCH v2 64/64] drm/xlnx: " Maxime Ripard
2026-11-17 13:22 ` [PATCH v2 00/64] drm: Switch drivers " Thomas Zimmermann
2026-11-17 13:22   ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216790@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mripard@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.