From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794827558; b=cDIIgGf5gBfPm6THZu9fliTHPDg0pg4HaI15L2Bi5YHSh5YCOmyLbdCn/Ag+2J/16WP9 1wRXJpwbkeNa/mAG3N3pUtu4YBdagPUuE5nCSPl5bbpsdyBRVhq9tUsNAcGwhRstiL9rJ nJXQk3xbmZnYIpNpBe4XDivPIL6Lpqg0rkIf5vYs0xfdxeZmcFN8c4n1vYV37nZlv3VtA i0HeXtCXgzDJ9E6gG+VSpNNHixdyUrzzjprovX/cu2VH1aT5lfo4IXK8t6JFuqrR6nz89 SMfacecX4vDXS4BGeRtN1Z46/MesLfHeQKLAYgLKHFs3zKJIUjS9pYB8n7Jsm2U0uLQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794827558; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=WQRQeJ+Gxgr7tiV9mblg5X2h9ycpLr64NDSACZWQz10=; b=fBvV+hXElf/3LjuWOJcvfHjdWVOKEdPg+eue7bJU9P8m0t1ZJ2k7wJf/O18DJYuEg4wZ 8QSAd09BPT955u2kPH1reeCYmpfet2DprRoZibk350hAfzawvxf23Q6D24e6xAyF+FUEV MYrZl7f5wUa6/fuBS7/u4D5lZqlJOCOoL6nBlVu3kD7wzkFqwMBIAz92l9WN5E6PiUjxo 0ir0qhH/a43bHeiboUzYL8c2fnXtEZihoNmusaePPE8p32CZrWdLGtHOgK9uxY+J+v11c 5cGSVi3a4iUedBvyIBeWy5kBJH/6BzMUnuOF7cYgPki4n3KqNeZLojIj6IIrCASUS+g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ibE8M9VW; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C207A606A32C; Mon, 16 Nov 2026 11:12:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ibE8M9VW Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2085E1F000C4; Mon, 16 Nov 2026 11:12:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794827558; bh=WQRQeJ+Gxgr7tiV9mblg5X2h9ycpLr64NDSACZWQz10=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ibE8M9VWl3o019TmgaoqEW4JP4HQfCoRfObVrIfvp/TC09fV7qmjVj6CKRVNIf0GR PjS5ouDBxXwqGa26XYOVs7fo18FhUFofWQ293UDuMlLj8NC43b6ca5EIFo0p242jv0 jkj85HKuT6pPmAcC/oBcZ5k8ZjjUvHfnMHdAggRnx7h4yTZn51N5Y/cC/PzKJLhmb5 d2HhVea+tck9yE3YyRcPFG5pB45YuWzMBVaqaw2BLRaQG9/GJhIo9/BK2/PEe+rFge bGQ2eX6OhLxl2S6MosX0DyN47cns9ycbTTFR2mnf6rUoqYLYbr+LJ6iiUd6CfSLdCC 1ICvKhtMCSYfw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 2/2] i3c: master: svc: Add amlogic a9 support Reply-To: sashiko-reviews@lists.linux.dev To: "Junyi Zhao" Cc: linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, imx@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org, neil.armstrong@linaro.org, "Alexandre Belloni" In-Reply-To: <20261116-a9_i3c-v4-2-3d3222b7128d@amlogic.com> References: <20261116-a9_i3c-v4-0-3d3222b7128d@amlogic.com> <20261116-a9_i3c-v4-2-3d3222b7128d@amlogic.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 16 Nov 2026 11:12:37 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 3 potential issues to consider: - [Medium] i3c: master: svc: NULL dereference of clks[0].id in aml_i3c_init() - [Medium] i3c: master: svc: clocks left enabled in svc_i3c_master_remove() - [Low] i3c: master: svc: duplicate fast_clk lookup in aml_i3c_init() -- commit 260aeb5a4d5c58d3bea32674062960231e4d4d2c Author: Junyi Zhao i3c: master: svc: Add amlogic a9 support This commit adds support for the Amlogic A9 EE-domain and AO-domain Silvaco I3C controllers, introducing a vendor_init callback to register the AO variant's internal clock divider chain and configure the fast_clk rate. > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc= -i3c-master.c > index e700392f0801f..0268fc713afdf 100644 > --- a/drivers/i3c/master/svc-i3c-master.c > +++ b/drivers/i3c/master/svc-i3c-master.c [ ... ] > @@ -2163,9 +2209,215 @@ static const struct svc_i3c_drvdata npcm845_drvda= ta =3D { [ ... ] > + /* > + * Keep the clk bulk state balanced for the following > + * clk_bulk_disable_unprepare() calls (error paths and runtime PM). > + */ > + ret =3D clk_prepare_enable(fclk); > + if (ret) > + return dev_err_probe(dev, ret, "can't enable fast_clk\n"); > + > + new_clks =3D devm_kcalloc(dev, master->num_clks + 1, sizeof(*new_clks), > + GFP_KERNEL); > + if (!new_clks) { > + clk_disable_unprepare(fclk); > + return -ENOMEM; > + } > + > + memcpy(new_clks, master->clks, > + master->num_clks * sizeof(*master->clks)); > + new_clks[master->num_clks].id =3D "fast_clk"; > + new_clks[master->num_clks].clk =3D fclk; > + master->clks =3D new_clks; > + master->num_clks++; > + > + return 0; > +} [Severity: Medium] Can unbinding the driver leave fclk and the input clocks enabled when the device is not runtime-suspended? svc_i3c_master_remove() calls pm_runtime_dont_use_autosuspend() and pm_runtime_disable(), relying on svc_i3c_runtime_suspend() to call clk_bulk_disable_unprepare(). If CONFIG_PM is disabled, runtime PM is forbidden via sysfs, or hotjoin is enabled (which holds a runtime PM reference not released by i3c_master_unregister()), runtime suspend does not run during remove. When devres then unregisters ao->gate.hw, ao->div.hw, and ao->div_en.hw while they are still prepared and enabled, clk_unregister() triggers a kernel warning and leaks the prepare and enable counts on the parent pclk. > + > +/** > + * aml_i3c_init - Amlogic A9 specific init, called with the clocks enabl= ed > + * @master: I3C master controller > + * > + * Register the AO variant's internal divider chain and round/set the fa= st > + * clock rate for both variants. > + * > + * Return: 0 on success, or a negative error code. > + */ > +static int aml_i3c_init(struct svc_i3c_master *master) > +{ > + struct device *dev =3D master->dev; > + struct clk *fclk; > + long fin_freq; > + int ret, i; > + > + if (svc_has_quirk(master, AML_I3C_QUIRK_AO)) { > + /* > + * clk_bulk_get_all() preserves the DT order, and the > + * binding restricts the AO variant to exactly one clock, > + * which is always "pclk". So clks[0] is the input of the > + * internal divider chain. > + */ > + if (strcmp(master->clks[0].id, "pclk")) > + return dev_err_probe(dev, -EINVAL, > + "invalid AO input clock\n"); [Severity: Medium] Can this trigger a NULL pointer dereference on master->clks or master->clks[0].id? When a device tree node has no clocks, devm_clk_bulk_get_all() returns 0 and leaves master->clks as NULL, which passes the master->num_clks < 0 check in svc_i3c_master_probe(). Previously, the fast_clk loop in probe ran zero iterations and returned -EINVAL, but aml_i3c_init() now runs first and indexes master->clks[0] without checking that master->num_clks is at least 1 (or equal to 1 as required by the AO binding). In addition, of_clk_bulk_get() leaves clks[i].id as NULL if clock-names is missing or shorter than clocks, which would cause strcmp() here and in the fast_clk loop below to dereference NULL. > + > + ret =3D aml_ao_i3c_tail_clocks(master, master->clks[0].clk); > + if (ret) > + return ret; > + } > + > + for (i =3D 0; i < master->num_clks; i++) { > + if (!strcmp(master->clks[i].id, "fast_clk")) > + break; > + } > + > + if (i =3D=3D master->num_clks) > + return dev_err_probe(dev, -EINVAL, > + "can't get I3C fast clock\n"); > + > + fclk =3D master->clks[i].clk; > + if (IS_ERR(fclk)) > + return PTR_ERR(fclk); [Severity: Low] This isn't a bug, but this fast_clk lookup and validation duplicates the identical loop in svc_i3c_master_probe() that runs right after vendor_init() returns. Could a shared helper or resolving master->fclk once avoid repeating the lookup? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261116-a9_i3c-v4-= 0-3d3222b7128d@amlogic.com?part=3D2 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05D0F606A32C for ; Mon, 16 Nov 2026 11:12:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=gxAwG0DH; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ibE8M9VW DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=p4PT/pAoSiJcK2rmbAGqV/iu4HL+0Zp5URYYnsJI/iY=; b=gxAwG0DHt2+Eki2CJZ+7LQ6UMn h6yoNdRxHFEw8OJOOGY9uSYj18wUkIK9PT0GUlWzNBScx8SVpAiXGEdWH6ChynRcniYnFzJ3V+MTM qbpZVCFZo1sXDgXNfkzvlnW+bFM6R+hcaLTA2OfC11Nm+w+s80kz2I4IuAiuNW4VAs5UYpQ/oz9S4 YqbakC4CnXdJqJSsf9JVnP/2seiMHf/9nYHACMyOqDnziL0cvbo77xX94BQeZ9Fj52E8rYOKCGikj 3LK9Uw8E6W7yW/ySR+hA5JS9zU/sUXLaTfKYk9MJ1KISozDHlzSFMZGkWNu2S/PMKJ8Hu5hQO3yMd K0ts9W3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xSudb-000000028Ct-39HF; Mon, 16 Nov 2026 11:12:39 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xSudb-000000028Cg-0FbI; Mon, 16 Nov 2026 11:12:39 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id BBA3643B1B; Mon, 16 Nov 2026 11:12:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2085E1F000C4; Mon, 16 Nov 2026 11:12:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794827558; bh=WQRQeJ+Gxgr7tiV9mblg5X2h9ycpLr64NDSACZWQz10=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ibE8M9VWl3o019TmgaoqEW4JP4HQfCoRfObVrIfvp/TC09fV7qmjVj6CKRVNIf0GR PjS5ouDBxXwqGa26XYOVs7fo18FhUFofWQ293UDuMlLj8NC43b6ca5EIFo0p242jv0 jkj85HKuT6pPmAcC/oBcZ5k8ZjjUvHfnMHdAggRnx7h4yTZn51N5Y/cC/PzKJLhmb5 d2HhVea+tck9yE3YyRcPFG5pB45YuWzMBVaqaw2BLRaQG9/GJhIo9/BK2/PEe+rFge bGQ2eX6OhLxl2S6MosX0DyN47cns9ycbTTFR2mnf6rUoqYLYbr+LJ6iiUd6CfSLdCC 1ICvKhtMCSYfw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 2/2] i3c: master: svc: Add amlogic a9 support To: "Junyi Zhao" Cc: linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, imx@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org, neil.armstrong@linaro.org, "Alexandre Belloni" In-Reply-To: <20261116-a9_i3c-v4-2-3d3222b7128d@amlogic.com> References: <20261116-a9_i3c-v4-0-3d3222b7128d@amlogic.com> <20261116-a9_i3c-v4-2-3d3222b7128d@amlogic.com> Date: Mon, 16 Nov 2026 11:12:37 +0000 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwKaXNzdWVzIHRvIGNvbnNpZGVyOgotIFtNZWRpdW1dIGkzYzogbWFzdGVyOiBz dmM6IE5VTEwgZGVyZWZlcmVuY2Ugb2YgY2xrc1swXS5pZCBpbgogIGFtbF9pM2NfaW5pdCgpCi0g W01lZGl1bV0gaTNjOiBtYXN0ZXI6IHN2YzogY2xvY2tzIGxlZnQgZW5hYmxlZCBpbgogIHN2Y19p M2NfbWFzdGVyX3JlbW92ZSgpCi0gW0xvd10gaTNjOiBtYXN0ZXI6IHN2YzogZHVwbGljYXRlIGZh c3RfY2xrIGxvb2t1cCBpbiBhbWxfaTNjX2luaXQoKQotLQoKY29tbWl0IDI2MGFlYjVhNGQ1YzU4 ZDNiZWEzMjY3NDA2Mjk2MDIzMWU0ZDRkMmMKQXV0aG9yOiBKdW55aSBaaGFvIDxqdW55aS56aGFv QGFtbG9naWMuY29tPgoKaTNjOiBtYXN0ZXI6IHN2YzogQWRkIGFtbG9naWMgYTkgc3VwcG9ydAoK VGhpcyBjb21taXQgYWRkcyBzdXBwb3J0IGZvciB0aGUgQW1sb2dpYyBBOSBFRS1kb21haW4gYW5k IEFPLWRvbWFpbiBTaWx2YWNvCkkzQyBjb250cm9sbGVycywgaW50cm9kdWNpbmcgYSB2ZW5kb3Jf aW5pdCBjYWxsYmFjayB0byByZWdpc3RlciB0aGUgQU8KdmFyaWFudCdzIGludGVybmFsIGNsb2Nr IGRpdmlkZXIgY2hhaW4gYW5kIGNvbmZpZ3VyZSB0aGUgZmFzdF9jbGsgcmF0ZS4KCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvaTNjL21hc3Rlci9zdmMtaTNjLW1hc3Rlci5jIGIvZHJpdmVycy9pM2Mv bWFzdGVyL3N2Yy1pM2MtbWFzdGVyLmMKPiBpbmRleCBlNzAwMzkyZjA4MDFmLi4wMjY4ZmM3MTNh ZmRmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvaTNjL21hc3Rlci9zdmMtaTNjLW1hc3Rlci5jCj4g KysrIGIvZHJpdmVycy9pM2MvbWFzdGVyL3N2Yy1pM2MtbWFzdGVyLmMKClsgLi4uIF0KCj4gQEAg LTIxNjMsOSArMjIwOSwyMTUgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBzdmNfaTNjX2RydmRhdGEg bnBjbTg0NV9kcnZkYXRhID0gewoKWyAuLi4gXQoKPiArCS8qCj4gKwkgKiBLZWVwIHRoZSBjbGsg YnVsayBzdGF0ZSBiYWxhbmNlZCBmb3IgdGhlIGZvbGxvd2luZwo+ICsJICogY2xrX2J1bGtfZGlz YWJsZV91bnByZXBhcmUoKSBjYWxscyAoZXJyb3IgcGF0aHMgYW5kIHJ1bnRpbWUgUE0pLgo+ICsJ ICovCj4gKwlyZXQgPSBjbGtfcHJlcGFyZV9lbmFibGUoZmNsayk7Cj4gKwlpZiAocmV0KQo+ICsJ CXJldHVybiBkZXZfZXJyX3Byb2JlKGRldiwgcmV0LCAiY2FuJ3QgZW5hYmxlIGZhc3RfY2xrXG4i KTsKPiArCj4gKwluZXdfY2xrcyA9IGRldm1fa2NhbGxvYyhkZXYsIG1hc3Rlci0+bnVtX2Nsa3Mg KyAxLCBzaXplb2YoKm5ld19jbGtzKSwKPiArCQkJCUdGUF9LRVJORUwpOwo+ICsJaWYgKCFuZXdf Y2xrcykgewo+ICsJCWNsa19kaXNhYmxlX3VucHJlcGFyZShmY2xrKTsKPiArCQlyZXR1cm4gLUVO T01FTTsKPiArCX0KPiArCj4gKwltZW1jcHkobmV3X2Nsa3MsIG1hc3Rlci0+Y2xrcywKPiArCSAg ICAgICBtYXN0ZXItPm51bV9jbGtzICogc2l6ZW9mKCptYXN0ZXItPmNsa3MpKTsKPiArCW5ld19j bGtzW21hc3Rlci0+bnVtX2Nsa3NdLmlkID0gImZhc3RfY2xrIjsKPiArCW5ld19jbGtzW21hc3Rl ci0+bnVtX2Nsa3NdLmNsayA9IGZjbGs7Cj4gKwltYXN0ZXItPmNsa3MgPSBuZXdfY2xrczsKPiAr CW1hc3Rlci0+bnVtX2Nsa3MrKzsKPiArCj4gKwlyZXR1cm4gMDsKPiArfQoKW1NldmVyaXR5OiBN ZWRpdW1dCkNhbiB1bmJpbmRpbmcgdGhlIGRyaXZlciBsZWF2ZSBmY2xrIGFuZCB0aGUgaW5wdXQg Y2xvY2tzIGVuYWJsZWQgd2hlbiB0aGUKZGV2aWNlIGlzIG5vdCBydW50aW1lLXN1c3BlbmRlZD8K CnN2Y19pM2NfbWFzdGVyX3JlbW92ZSgpIGNhbGxzIHBtX3J1bnRpbWVfZG9udF91c2VfYXV0b3N1 c3BlbmQoKSBhbmQKcG1fcnVudGltZV9kaXNhYmxlKCksIHJlbHlpbmcgb24gc3ZjX2kzY19ydW50 aW1lX3N1c3BlbmQoKSB0byBjYWxsCmNsa19idWxrX2Rpc2FibGVfdW5wcmVwYXJlKCkuICBJZiBD T05GSUdfUE0gaXMgZGlzYWJsZWQsIHJ1bnRpbWUgUE0gaXMKZm9yYmlkZGVuIHZpYSBzeXNmcywg b3IgaG90am9pbiBpcyBlbmFibGVkICh3aGljaCBob2xkcyBhIHJ1bnRpbWUgUE0KcmVmZXJlbmNl IG5vdCByZWxlYXNlZCBieSBpM2NfbWFzdGVyX3VucmVnaXN0ZXIoKSksIHJ1bnRpbWUgc3VzcGVu ZCBkb2VzCm5vdCBydW4gZHVyaW5nIHJlbW92ZS4gIFdoZW4gZGV2cmVzIHRoZW4gdW5yZWdpc3Rl cnMgYW8tPmdhdGUuaHcsCmFvLT5kaXYuaHcsIGFuZCBhby0+ZGl2X2VuLmh3IHdoaWxlIHRoZXkg YXJlIHN0aWxsIHByZXBhcmVkIGFuZCBlbmFibGVkLApjbGtfdW5yZWdpc3RlcigpIHRyaWdnZXJz IGEga2VybmVsIHdhcm5pbmcgYW5kIGxlYWtzIHRoZSBwcmVwYXJlIGFuZAplbmFibGUgY291bnRz IG9uIHRoZSBwYXJlbnQgcGNsay4KCj4gKwo+ICsvKioKPiArICogYW1sX2kzY19pbml0IC0gQW1s b2dpYyBBOSBzcGVjaWZpYyBpbml0LCBjYWxsZWQgd2l0aCB0aGUgY2xvY2tzIGVuYWJsZWQKPiAr ICogQG1hc3RlcjogSTNDIG1hc3RlciBjb250cm9sbGVyCj4gKyAqCj4gKyAqIFJlZ2lzdGVyIHRo ZSBBTyB2YXJpYW50J3MgaW50ZXJuYWwgZGl2aWRlciBjaGFpbiBhbmQgcm91bmQvc2V0IHRoZSBm YXN0Cj4gKyAqIGNsb2NrIHJhdGUgZm9yIGJvdGggdmFyaWFudHMuCj4gKyAqCj4gKyAqIFJldHVy bjogMCBvbiBzdWNjZXNzLCBvciBhIG5lZ2F0aXZlIGVycm9yIGNvZGUuCj4gKyAqLwo+ICtzdGF0 aWMgaW50IGFtbF9pM2NfaW5pdChzdHJ1Y3Qgc3ZjX2kzY19tYXN0ZXIgKm1hc3RlcikKPiArewo+ ICsJc3RydWN0IGRldmljZSAqZGV2ID0gbWFzdGVyLT5kZXY7Cj4gKwlzdHJ1Y3QgY2xrICpmY2xr Owo+ICsJbG9uZyBmaW5fZnJlcTsKPiArCWludCByZXQsIGk7Cj4gKwo+ICsJaWYgKHN2Y19oYXNf cXVpcmsobWFzdGVyLCBBTUxfSTNDX1FVSVJLX0FPKSkgewo+ICsJCS8qCj4gKwkJICogY2xrX2J1 bGtfZ2V0X2FsbCgpIHByZXNlcnZlcyB0aGUgRFQgb3JkZXIsIGFuZCB0aGUKPiArCQkgKiBiaW5k aW5nIHJlc3RyaWN0cyB0aGUgQU8gdmFyaWFudCB0byBleGFjdGx5IG9uZSBjbG9jaywKPiArCQkg KiB3aGljaCBpcyBhbHdheXMgInBjbGsiLiAgU28gY2xrc1swXSBpcyB0aGUgaW5wdXQgb2YgdGhl Cj4gKwkJICogaW50ZXJuYWwgZGl2aWRlciBjaGFpbi4KPiArCQkgKi8KPiArCQlpZiAoc3RyY21w KG1hc3Rlci0+Y2xrc1swXS5pZCwgInBjbGsiKSkKPiArCQkJcmV0dXJuIGRldl9lcnJfcHJvYmUo ZGV2LCAtRUlOVkFMLAo+ICsJCQkJCSAgICAgImludmFsaWQgQU8gaW5wdXQgY2xvY2tcbiIpOwoK W1NldmVyaXR5OiBNZWRpdW1dCkNhbiB0aGlzIHRyaWdnZXIgYSBOVUxMIHBvaW50ZXIgZGVyZWZl cmVuY2Ugb24gbWFzdGVyLT5jbGtzIG9yCm1hc3Rlci0+Y2xrc1swXS5pZD8KCldoZW4gYSBkZXZp Y2UgdHJlZSBub2RlIGhhcyBubyBjbG9ja3MsIGRldm1fY2xrX2J1bGtfZ2V0X2FsbCgpIHJldHVy bnMgMAphbmQgbGVhdmVzIG1hc3Rlci0+Y2xrcyBhcyBOVUxMLCB3aGljaCBwYXNzZXMgdGhlIG1h c3Rlci0+bnVtX2Nsa3MgPCAwCmNoZWNrIGluIHN2Y19pM2NfbWFzdGVyX3Byb2JlKCkuICBQcmV2 aW91c2x5LCB0aGUgZmFzdF9jbGsgbG9vcCBpbiBwcm9iZQpyYW4gemVybyBpdGVyYXRpb25zIGFu ZCByZXR1cm5lZCAtRUlOVkFMLCBidXQgYW1sX2kzY19pbml0KCkgbm93IHJ1bnMKZmlyc3QgYW5k IGluZGV4ZXMgbWFzdGVyLT5jbGtzWzBdIHdpdGhvdXQgY2hlY2tpbmcgdGhhdCBtYXN0ZXItPm51 bV9jbGtzCmlzIGF0IGxlYXN0IDEgKG9yIGVxdWFsIHRvIDEgYXMgcmVxdWlyZWQgYnkgdGhlIEFP IGJpbmRpbmcpLiAgSW4gYWRkaXRpb24sCm9mX2Nsa19idWxrX2dldCgpIGxlYXZlcyBjbGtzW2ld LmlkIGFzIE5VTEwgaWYgY2xvY2stbmFtZXMgaXMgbWlzc2luZyBvcgpzaG9ydGVyIHRoYW4gY2xv Y2tzLCB3aGljaCB3b3VsZCBjYXVzZSBzdHJjbXAoKSBoZXJlIGFuZCBpbiB0aGUgZmFzdF9jbGsK bG9vcCBiZWxvdyB0byBkZXJlZmVyZW5jZSBOVUxMLgoKPiArCj4gKwkJcmV0ID0gYW1sX2FvX2kz Y190YWlsX2Nsb2NrcyhtYXN0ZXIsIG1hc3Rlci0+Y2xrc1swXS5jbGspOwo+ICsJCWlmIChyZXQp Cj4gKwkJCXJldHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICsJZm9yIChpID0gMDsgaSA8IG1hc3Rlci0+ bnVtX2Nsa3M7IGkrKykgewo+ICsJCWlmICghc3RyY21wKG1hc3Rlci0+Y2xrc1tpXS5pZCwgImZh c3RfY2xrIikpCj4gKwkJCWJyZWFrOwo+ICsJfQo+ICsKPiArCWlmIChpID09IG1hc3Rlci0+bnVt X2Nsa3MpCj4gKwkJcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCAtRUlOVkFMLAo+ICsJCQkJICAg ICAiY2FuJ3QgZ2V0IEkzQyBmYXN0IGNsb2NrXG4iKTsKPiArCj4gKwlmY2xrID0gbWFzdGVyLT5j bGtzW2ldLmNsazsKPiArCWlmIChJU19FUlIoZmNsaykpCj4gKwkJcmV0dXJuIFBUUl9FUlIoZmNs ayk7CgpbU2V2ZXJpdHk6IExvd10KVGhpcyBpc24ndCBhIGJ1ZywgYnV0IHRoaXMgZmFzdF9jbGsg bG9va3VwIGFuZCB2YWxpZGF0aW9uIGR1cGxpY2F0ZXMgdGhlCmlkZW50aWNhbCBsb29wIGluIHN2 Y19pM2NfbWFzdGVyX3Byb2JlKCkgdGhhdCBydW5zIHJpZ2h0IGFmdGVyCnZlbmRvcl9pbml0KCkg cmV0dXJucy4gIENvdWxkIGEgc2hhcmVkIGhlbHBlciBvciByZXNvbHZpbmcgbWFzdGVyLT5mY2xr Cm9uY2UgYXZvaWQgcmVwZWF0aW5nIHRoZSBsb29rdXA/CgotLSAKU2FzaGlrbyBBSSByZXZpZXcg wrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYxMTE2LWE5X2kzYy12NC0wLTNk MzIyMmI3MTI4ZEBhbWxvZ2ljLmNvbT9wYXJ0PTIKCi0tIApsaW51eC1pM2MgbWFpbGluZyBsaXN0 CmxpbnV4LWkzY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtaTNjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07F6E606A31C for ; Mon, 16 Nov 2026 11:12:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=mxczrUn4; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ibE8M9VW DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=mkm9qBCVe3c03Pilr3MyCP+/Ndayf42pOpWf0GU3O5g=; b=mxczrUn4EywFE5rq44haXhjp5+ rfSTo7gwfvztev9Hh1abg3AA+2tQPwClpeAi3/sWRVcD/QnsCRxM6j22yp5pwT+4emNEEsJGmAfm7 ChA410Nb8KpO4AhqnTzfTDmg9wdbCNcTHhMFR0m9LOt1oQXyL9Xo5YX80jliD1BRC2PIccnS+td1W WqnPKHGW/EPGi696Pk/uLb5DemyPxA9T0Isk04mg3OEWfqzdSUHQCphw9+5/ju3DfF3O/3MxFGyeu RC9P59gwT1IJXXTqoX82AzRIHU5CuDmM+l+Mxwgwm3cLaTrU4FU8YGTXWdhkyQSYKBSkYuQvk4/5O n54qUvcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xSudb-000000028Cp-2zQK; Mon, 16 Nov 2026 11:12:39 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xSudb-000000028Cg-0FbI; Mon, 16 Nov 2026 11:12:39 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id BBA3643B1B; Mon, 16 Nov 2026 11:12:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2085E1F000C4; Mon, 16 Nov 2026 11:12:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794827558; bh=WQRQeJ+Gxgr7tiV9mblg5X2h9ycpLr64NDSACZWQz10=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ibE8M9VWl3o019TmgaoqEW4JP4HQfCoRfObVrIfvp/TC09fV7qmjVj6CKRVNIf0GR PjS5ouDBxXwqGa26XYOVs7fo18FhUFofWQ293UDuMlLj8NC43b6ca5EIFo0p242jv0 jkj85HKuT6pPmAcC/oBcZ5k8ZjjUvHfnMHdAggRnx7h4yTZn51N5Y/cC/PzKJLhmb5 d2HhVea+tck9yE3YyRcPFG5pB45YuWzMBVaqaw2BLRaQG9/GJhIo9/BK2/PEe+rFge bGQ2eX6OhLxl2S6MosX0DyN47cns9ycbTTFR2mnf6rUoqYLYbr+LJ6iiUd6CfSLdCC 1ICvKhtMCSYfw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 2/2] i3c: master: svc: Add amlogic a9 support To: "Junyi Zhao" Cc: linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, imx@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org, neil.armstrong@linaro.org, "Alexandre Belloni" In-Reply-To: <20261116-a9_i3c-v4-2-3d3222b7128d@amlogic.com> References: <20261116-a9_i3c-v4-0-3d3222b7128d@amlogic.com> <20261116-a9_i3c-v4-2-3d3222b7128d@amlogic.com> Date: Mon, 16 Nov 2026 11:12:37 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwKaXNzdWVzIHRvIGNvbnNpZGVyOgotIFtNZWRpdW1dIGkzYzogbWFzdGVyOiBz dmM6IE5VTEwgZGVyZWZlcmVuY2Ugb2YgY2xrc1swXS5pZCBpbgogIGFtbF9pM2NfaW5pdCgpCi0g W01lZGl1bV0gaTNjOiBtYXN0ZXI6IHN2YzogY2xvY2tzIGxlZnQgZW5hYmxlZCBpbgogIHN2Y19p M2NfbWFzdGVyX3JlbW92ZSgpCi0gW0xvd10gaTNjOiBtYXN0ZXI6IHN2YzogZHVwbGljYXRlIGZh c3RfY2xrIGxvb2t1cCBpbiBhbWxfaTNjX2luaXQoKQotLQoKY29tbWl0IDI2MGFlYjVhNGQ1YzU4 ZDNiZWEzMjY3NDA2Mjk2MDIzMWU0ZDRkMmMKQXV0aG9yOiBKdW55aSBaaGFvIDxqdW55aS56aGFv QGFtbG9naWMuY29tPgoKaTNjOiBtYXN0ZXI6IHN2YzogQWRkIGFtbG9naWMgYTkgc3VwcG9ydAoK VGhpcyBjb21taXQgYWRkcyBzdXBwb3J0IGZvciB0aGUgQW1sb2dpYyBBOSBFRS1kb21haW4gYW5k IEFPLWRvbWFpbiBTaWx2YWNvCkkzQyBjb250cm9sbGVycywgaW50cm9kdWNpbmcgYSB2ZW5kb3Jf aW5pdCBjYWxsYmFjayB0byByZWdpc3RlciB0aGUgQU8KdmFyaWFudCdzIGludGVybmFsIGNsb2Nr IGRpdmlkZXIgY2hhaW4gYW5kIGNvbmZpZ3VyZSB0aGUgZmFzdF9jbGsgcmF0ZS4KCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvaTNjL21hc3Rlci9zdmMtaTNjLW1hc3Rlci5jIGIvZHJpdmVycy9pM2Mv bWFzdGVyL3N2Yy1pM2MtbWFzdGVyLmMKPiBpbmRleCBlNzAwMzkyZjA4MDFmLi4wMjY4ZmM3MTNh ZmRmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvaTNjL21hc3Rlci9zdmMtaTNjLW1hc3Rlci5jCj4g KysrIGIvZHJpdmVycy9pM2MvbWFzdGVyL3N2Yy1pM2MtbWFzdGVyLmMKClsgLi4uIF0KCj4gQEAg LTIxNjMsOSArMjIwOSwyMTUgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBzdmNfaTNjX2RydmRhdGEg bnBjbTg0NV9kcnZkYXRhID0gewoKWyAuLi4gXQoKPiArCS8qCj4gKwkgKiBLZWVwIHRoZSBjbGsg YnVsayBzdGF0ZSBiYWxhbmNlZCBmb3IgdGhlIGZvbGxvd2luZwo+ICsJICogY2xrX2J1bGtfZGlz YWJsZV91bnByZXBhcmUoKSBjYWxscyAoZXJyb3IgcGF0aHMgYW5kIHJ1bnRpbWUgUE0pLgo+ICsJ ICovCj4gKwlyZXQgPSBjbGtfcHJlcGFyZV9lbmFibGUoZmNsayk7Cj4gKwlpZiAocmV0KQo+ICsJ CXJldHVybiBkZXZfZXJyX3Byb2JlKGRldiwgcmV0LCAiY2FuJ3QgZW5hYmxlIGZhc3RfY2xrXG4i KTsKPiArCj4gKwluZXdfY2xrcyA9IGRldm1fa2NhbGxvYyhkZXYsIG1hc3Rlci0+bnVtX2Nsa3Mg KyAxLCBzaXplb2YoKm5ld19jbGtzKSwKPiArCQkJCUdGUF9LRVJORUwpOwo+ICsJaWYgKCFuZXdf Y2xrcykgewo+ICsJCWNsa19kaXNhYmxlX3VucHJlcGFyZShmY2xrKTsKPiArCQlyZXR1cm4gLUVO T01FTTsKPiArCX0KPiArCj4gKwltZW1jcHkobmV3X2Nsa3MsIG1hc3Rlci0+Y2xrcywKPiArCSAg ICAgICBtYXN0ZXItPm51bV9jbGtzICogc2l6ZW9mKCptYXN0ZXItPmNsa3MpKTsKPiArCW5ld19j bGtzW21hc3Rlci0+bnVtX2Nsa3NdLmlkID0gImZhc3RfY2xrIjsKPiArCW5ld19jbGtzW21hc3Rl ci0+bnVtX2Nsa3NdLmNsayA9IGZjbGs7Cj4gKwltYXN0ZXItPmNsa3MgPSBuZXdfY2xrczsKPiAr CW1hc3Rlci0+bnVtX2Nsa3MrKzsKPiArCj4gKwlyZXR1cm4gMDsKPiArfQoKW1NldmVyaXR5OiBN ZWRpdW1dCkNhbiB1bmJpbmRpbmcgdGhlIGRyaXZlciBsZWF2ZSBmY2xrIGFuZCB0aGUgaW5wdXQg Y2xvY2tzIGVuYWJsZWQgd2hlbiB0aGUKZGV2aWNlIGlzIG5vdCBydW50aW1lLXN1c3BlbmRlZD8K CnN2Y19pM2NfbWFzdGVyX3JlbW92ZSgpIGNhbGxzIHBtX3J1bnRpbWVfZG9udF91c2VfYXV0b3N1 c3BlbmQoKSBhbmQKcG1fcnVudGltZV9kaXNhYmxlKCksIHJlbHlpbmcgb24gc3ZjX2kzY19ydW50 aW1lX3N1c3BlbmQoKSB0byBjYWxsCmNsa19idWxrX2Rpc2FibGVfdW5wcmVwYXJlKCkuICBJZiBD T05GSUdfUE0gaXMgZGlzYWJsZWQsIHJ1bnRpbWUgUE0gaXMKZm9yYmlkZGVuIHZpYSBzeXNmcywg b3IgaG90am9pbiBpcyBlbmFibGVkICh3aGljaCBob2xkcyBhIHJ1bnRpbWUgUE0KcmVmZXJlbmNl IG5vdCByZWxlYXNlZCBieSBpM2NfbWFzdGVyX3VucmVnaXN0ZXIoKSksIHJ1bnRpbWUgc3VzcGVu ZCBkb2VzCm5vdCBydW4gZHVyaW5nIHJlbW92ZS4gIFdoZW4gZGV2cmVzIHRoZW4gdW5yZWdpc3Rl cnMgYW8tPmdhdGUuaHcsCmFvLT5kaXYuaHcsIGFuZCBhby0+ZGl2X2VuLmh3IHdoaWxlIHRoZXkg YXJlIHN0aWxsIHByZXBhcmVkIGFuZCBlbmFibGVkLApjbGtfdW5yZWdpc3RlcigpIHRyaWdnZXJz IGEga2VybmVsIHdhcm5pbmcgYW5kIGxlYWtzIHRoZSBwcmVwYXJlIGFuZAplbmFibGUgY291bnRz IG9uIHRoZSBwYXJlbnQgcGNsay4KCj4gKwo+ICsvKioKPiArICogYW1sX2kzY19pbml0IC0gQW1s b2dpYyBBOSBzcGVjaWZpYyBpbml0LCBjYWxsZWQgd2l0aCB0aGUgY2xvY2tzIGVuYWJsZWQKPiAr ICogQG1hc3RlcjogSTNDIG1hc3RlciBjb250cm9sbGVyCj4gKyAqCj4gKyAqIFJlZ2lzdGVyIHRo ZSBBTyB2YXJpYW50J3MgaW50ZXJuYWwgZGl2aWRlciBjaGFpbiBhbmQgcm91bmQvc2V0IHRoZSBm YXN0Cj4gKyAqIGNsb2NrIHJhdGUgZm9yIGJvdGggdmFyaWFudHMuCj4gKyAqCj4gKyAqIFJldHVy bjogMCBvbiBzdWNjZXNzLCBvciBhIG5lZ2F0aXZlIGVycm9yIGNvZGUuCj4gKyAqLwo+ICtzdGF0 aWMgaW50IGFtbF9pM2NfaW5pdChzdHJ1Y3Qgc3ZjX2kzY19tYXN0ZXIgKm1hc3RlcikKPiArewo+ ICsJc3RydWN0IGRldmljZSAqZGV2ID0gbWFzdGVyLT5kZXY7Cj4gKwlzdHJ1Y3QgY2xrICpmY2xr Owo+ICsJbG9uZyBmaW5fZnJlcTsKPiArCWludCByZXQsIGk7Cj4gKwo+ICsJaWYgKHN2Y19oYXNf cXVpcmsobWFzdGVyLCBBTUxfSTNDX1FVSVJLX0FPKSkgewo+ICsJCS8qCj4gKwkJICogY2xrX2J1 bGtfZ2V0X2FsbCgpIHByZXNlcnZlcyB0aGUgRFQgb3JkZXIsIGFuZCB0aGUKPiArCQkgKiBiaW5k aW5nIHJlc3RyaWN0cyB0aGUgQU8gdmFyaWFudCB0byBleGFjdGx5IG9uZSBjbG9jaywKPiArCQkg KiB3aGljaCBpcyBhbHdheXMgInBjbGsiLiAgU28gY2xrc1swXSBpcyB0aGUgaW5wdXQgb2YgdGhl Cj4gKwkJICogaW50ZXJuYWwgZGl2aWRlciBjaGFpbi4KPiArCQkgKi8KPiArCQlpZiAoc3RyY21w KG1hc3Rlci0+Y2xrc1swXS5pZCwgInBjbGsiKSkKPiArCQkJcmV0dXJuIGRldl9lcnJfcHJvYmUo ZGV2LCAtRUlOVkFMLAo+ICsJCQkJCSAgICAgImludmFsaWQgQU8gaW5wdXQgY2xvY2tcbiIpOwoK W1NldmVyaXR5OiBNZWRpdW1dCkNhbiB0aGlzIHRyaWdnZXIgYSBOVUxMIHBvaW50ZXIgZGVyZWZl cmVuY2Ugb24gbWFzdGVyLT5jbGtzIG9yCm1hc3Rlci0+Y2xrc1swXS5pZD8KCldoZW4gYSBkZXZp Y2UgdHJlZSBub2RlIGhhcyBubyBjbG9ja3MsIGRldm1fY2xrX2J1bGtfZ2V0X2FsbCgpIHJldHVy bnMgMAphbmQgbGVhdmVzIG1hc3Rlci0+Y2xrcyBhcyBOVUxMLCB3aGljaCBwYXNzZXMgdGhlIG1h c3Rlci0+bnVtX2Nsa3MgPCAwCmNoZWNrIGluIHN2Y19pM2NfbWFzdGVyX3Byb2JlKCkuICBQcmV2 aW91c2x5LCB0aGUgZmFzdF9jbGsgbG9vcCBpbiBwcm9iZQpyYW4gemVybyBpdGVyYXRpb25zIGFu ZCByZXR1cm5lZCAtRUlOVkFMLCBidXQgYW1sX2kzY19pbml0KCkgbm93IHJ1bnMKZmlyc3QgYW5k IGluZGV4ZXMgbWFzdGVyLT5jbGtzWzBdIHdpdGhvdXQgY2hlY2tpbmcgdGhhdCBtYXN0ZXItPm51 bV9jbGtzCmlzIGF0IGxlYXN0IDEgKG9yIGVxdWFsIHRvIDEgYXMgcmVxdWlyZWQgYnkgdGhlIEFP IGJpbmRpbmcpLiAgSW4gYWRkaXRpb24sCm9mX2Nsa19idWxrX2dldCgpIGxlYXZlcyBjbGtzW2ld LmlkIGFzIE5VTEwgaWYgY2xvY2stbmFtZXMgaXMgbWlzc2luZyBvcgpzaG9ydGVyIHRoYW4gY2xv Y2tzLCB3aGljaCB3b3VsZCBjYXVzZSBzdHJjbXAoKSBoZXJlIGFuZCBpbiB0aGUgZmFzdF9jbGsK bG9vcCBiZWxvdyB0byBkZXJlZmVyZW5jZSBOVUxMLgoKPiArCj4gKwkJcmV0ID0gYW1sX2FvX2kz Y190YWlsX2Nsb2NrcyhtYXN0ZXIsIG1hc3Rlci0+Y2xrc1swXS5jbGspOwo+ICsJCWlmIChyZXQp Cj4gKwkJCXJldHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICsJZm9yIChpID0gMDsgaSA8IG1hc3Rlci0+ bnVtX2Nsa3M7IGkrKykgewo+ICsJCWlmICghc3RyY21wKG1hc3Rlci0+Y2xrc1tpXS5pZCwgImZh c3RfY2xrIikpCj4gKwkJCWJyZWFrOwo+ICsJfQo+ICsKPiArCWlmIChpID09IG1hc3Rlci0+bnVt X2Nsa3MpCj4gKwkJcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCAtRUlOVkFMLAo+ICsJCQkJICAg ICAiY2FuJ3QgZ2V0IEkzQyBmYXN0IGNsb2NrXG4iKTsKPiArCj4gKwlmY2xrID0gbWFzdGVyLT5j bGtzW2ldLmNsazsKPiArCWlmIChJU19FUlIoZmNsaykpCj4gKwkJcmV0dXJuIFBUUl9FUlIoZmNs ayk7CgpbU2V2ZXJpdHk6IExvd10KVGhpcyBpc24ndCBhIGJ1ZywgYnV0IHRoaXMgZmFzdF9jbGsg bG9va3VwIGFuZCB2YWxpZGF0aW9uIGR1cGxpY2F0ZXMgdGhlCmlkZW50aWNhbCBsb29wIGluIHN2 Y19pM2NfbWFzdGVyX3Byb2JlKCkgdGhhdCBydW5zIHJpZ2h0IGFmdGVyCnZlbmRvcl9pbml0KCkg cmV0dXJucy4gIENvdWxkIGEgc2hhcmVkIGhlbHBlciBvciByZXNvbHZpbmcgbWFzdGVyLT5mY2xr Cm9uY2UgYXZvaWQgcmVwZWF0aW5nIHRoZSBsb29rdXA/CgotLSAKU2FzaGlrbyBBSSByZXZpZXcg wrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYxMTE2LWE5X2kzYy12NC0wLTNk MzIyMmI3MTI4ZEBhbWxvZ2ljLmNvbT9wYXJ0PTIKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFtbG9naWMgbWFpbGluZyBsaXN0CmxpbnV4LWFt bG9naWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFtbG9naWMK