From: sashiko-bot@kernel.org
To: "Radhey Shyam Pandey" <radhey.shyam.pandey@amd.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: skip extcon lookup for fixed-role mode
Date: Mon, 16 Nov 2026 13:06:33 +0000 [thread overview]
Message-ID: <sashiko-outbox-217038@kernel.org> (raw)
In-Reply-To: <20261116125705.323670-1-radhey.shyam.pandey@amd.com>
> As a last resort dwc3_get_extcon() walks the OF graph from the "phys"
> phandle and asks extcon for a device bound to the remote node. A PHY
> "port" node no longer implies an extcon provider though: it may link
> to a Type-C controller for orientation switching. There
> extcon_find_edev_by_node() returns -EPROBE_DEFER, the same value it
> uses for "not registered yet", so the probe defers forever.
>
> An extcon is only consulted for role switching in OTG mode, so skip
> the graph walk for a fixed role. dwc->dr_mode is still the raw device
> tree value here, as dwc3_get_dr_mode() runs after the lookup, so also
> derive the fixed cases it would force from GHWPARAMS0 and from the
> Kconfig role selection. Its remaining OTG to peripheral downgrade
> cannot be covered because it consumes dwc->edev, but it is only
> reached once the lookup has already returned NULL.
>
> The check stays below the explicit "extcon" and "linux,extcon-name"
> lookups so those keep working for a fixed role.
>
> Fixes: d182c2e1bc92 ("usb: dwc3: Don't switch OTG -> peripheral if extcon is present")
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116125705.323670-1-radhey.shyam.pandey@amd.com?part=1
prev parent reply other threads:[~2026-11-16 13:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 12:57 [PATCH] usb: dwc3: skip extcon lookup for fixed-role mode Radhey Shyam Pandey
2026-11-16 13:06 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217038@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=radhey.shyam.pandey@amd.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.