From: sashiko-bot@kernel.org
To: "Vinayak Katoch" <vinayak.katoch@oss.qualcomm.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 2/2] misc: fastrpc: fix init ordering race in rpmsg probe
Date: Mon, 16 Nov 2026 13:51:03 +0000 [thread overview]
Message-ID: <sashiko-outbox-217114@kernel.org> (raw)
In-Reply-To: <20261116-fastrpc-probe-fixes-v3-2-3cd56d9d9a93@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] misc: fastrpc: dangling drvdata and dma_mask on
fastrpc_rpmsg_probe() error
- [Low] misc: fastrpc: inaccurate Fixes trailer in fastrpc_rpmsg_probe()
commit
--
commit 4a1cfc3ddafb9d12682d2f0bc78e07af7648cf89
Author: Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>
> misc: fastrpc: fix init ordering race in rpmsg probe
>
> fastrpc_device_register() calls misc_register() which makes the device
> node visible to userspace. However, kref_init(), spin_lock_init(),
> INIT_LIST_HEAD(), dev_set_drvdata() and of_platform_populate()
> were all called after the switch/misc_register block, leaving a window
> where userspace can open the device and call fastrpc_device_open() on
> a partially initialised channel context.
>
> On a concurrent open(), fastrpc_channel_ctx_get() calls kref_get() on
> a kzalloc-zeroed, never kref_init()'d refcount of 0, triggering:
>
> refcount_t: addition on 0; use-after-free.
> Call trace:
> refcount_warn_saturate+0x120/0x148 (P)
> fastrpc_device_open+0x204/0x258 [fastrpc]
> misc_open+0xd8/0x1a0
>
> Additionally, of_platform_populate() not having run means
> sesscount is still 0, so fastrpc_session_alloc() returns NULL and
> fastrpc_device_open() hits the error path which calls
> fastrpc_channel_ctx_put() on the already-bogus refcount. This
> triggers the free callback, kfree()-ing the channel context. A
> subsequent IRQ-path fastrpc_rpmsg_callback() then dereferences the
> freed spinlock:
>
> Unable to handle kernel paging request at virtual address ffffcd5841510ca0
> Internal error: Oops: 0000000096000047 [#1] SMP
> Call trace:
> queued_spin_lock_slowpath+0x414/0x5e0 (P)
> _raw_spin_lock_irqsave+0x74/0x90
> fastrpc_rpmsg_callback+0x4c/0xf0 [fastrpc]
> qcom_glink_native_rx+0x6c4/0xf10
> qcom_glink_smem_intr+0x1c/0x38 [qcom_glink_smem]
> Kernel panic - not syncing: Oops: Fatal exception in interrupt
>
> Fix by moving all channel context initialisation (kref_init,
> spin_lock_init, INIT_LIST_HEAD, idr_init, dev_set_drvdata) and
> of_platform_populate() before fastrpc_device_register(), ensuring
> the struct is fully ready before the device node is visible to
> userspace.
>
> Add err_depopulate label in the error path since
> of_platform_populate() now runs before misc_register(); a
> fastrpc_device_register() failure must call of_platform_depopulate()
> to clean up the compute-cb children.
>
> On CDSP/GDSP the secure node is registered before the non-secure one, so
> an application may already have opened the first node and hold a channel
> context reference when the second registration fails. Freeing the
> context with kfree() there would leave that user with a dangling
> pointer. Handle it like fastrpc_rpmsg_remove(): after the nodes are
> deregistered, clear rpdev, wake pending invocations with -EPIPE and drop
> only the probe reference with fastrpc_channel_ctx_put(), so the last
> holder frees the context. Move fastrpc_notify_users() above probe so it
> can be used there.
>
> Fixes: 965602eabb57 ("misc: fastrpc: separate fastrpc device from channel context")
> Cc: stable@vger.kernel.org
> Signed-off-by: Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>
[Severity: Low]
Is 965602eabb57 ("misc: fastrpc: separate fastrpc device from channel
context") the right commit for the Fixes tag?
That commit only factored misc_register() into fastrpc_device_register() at
the same position in fastrpc_rpmsg_probe(). Calling misc_register() before
spin_lock_init(), INIT_LIST_HEAD(), idr_init() and of_platform_populate()
dates back to f6f9279f2bf0 ("misc: fastrpc: Add Qualcomm fastrpc basic
driver model"), and the kref_init() ordering issue was introduced in
278d56f970ae ("misc: fastrpc: Reference count channel context").
> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
> index da0b2333a3ca3..0bbc1e00001ca 100644
> --- a/drivers/misc/fastrpc.c
> +++ b/drivers/misc/fastrpc.c
[ ... ]
> @@ -2599,6 +2613,23 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev)
> data->poll_mode_supported = soc_data->poll_mode_supported ||
> of_machine_get_match(fastrpc_poll_supported_machines);
>
> + kref_init(&data->refcount);
> + atomic_set(&data->ctx_seq, 0);
> +
> + rdev->dma_mask = &data->dma_mask;
> + dma_set_mask_and_coherent(rdev, DMA_BIT_MASK(32));
> + INIT_LIST_HEAD(&data->users);
> + INIT_LIST_HEAD(&data->invoke_interrupted_mmaps);
> + spin_lock_init(&data->lock);
> + idr_init(&data->ctx_idr);
> + data->domain_id = domain_id;
> + data->rpdev = rpdev;
> + dev_set_drvdata(&rpdev->dev, data);
> +
> + err = of_platform_populate(rdev->of_node, NULL, NULL, rdev);
> + if (err)
> + goto err_free_data;
> +
> switch (domain_id) {
> case ADSP_DOMAIN_ID:
> case MDSP_DOMAIN_ID:
> @@ -2607,7 +2638,7 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev)
> data->unsigned_support = false;
> err = fastrpc_device_register(rdev, data, secure_dsp, domain);
> if (err)
> - goto err_free_data;
> + goto err_depopulate;
> break;
> case CDSP_DOMAIN_ID:
> case GDSP_DOMAIN_ID:
> @@ -2615,7 +2646,7 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev)
> /* Create both device nodes so that we can allow both Signed and Unsigned PD */
> err = fastrpc_device_register(rdev, data, true, domain);
> if (err)
> - goto err_free_data;
> + goto err_depopulate;
>
> err = fastrpc_device_register(rdev, data, false, domain);
> if (err)
> @@ -2623,26 +2654,9 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev)
> break;
> default:
> err = -EINVAL;
> - goto err_free_data;
> + goto err_depopulate;
> }
>
> - kref_init(&data->refcount);
> - atomic_set(&data->ctx_seq, 0);
> -
> - rdev->dma_mask = &data->dma_mask;
> - dma_set_mask_and_coherent(rdev, DMA_BIT_MASK(32));
> - INIT_LIST_HEAD(&data->users);
> - INIT_LIST_HEAD(&data->invoke_interrupted_mmaps);
> - spin_lock_init(&data->lock);
> - idr_init(&data->ctx_idr);
> - data->domain_id = domain_id;
> - data->rpdev = rpdev;
> - dev_set_drvdata(&rpdev->dev, data);
> -
> - err = of_platform_populate(rdev->of_node, NULL, NULL, rdev);
> - if (err)
> - goto err_deregister_fdev;
> -
> return 0;
>
> err_deregister_fdev:
> @@ -2651,23 +2665,27 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev)
> if (data->secure_fdevice)
> misc_deregister(&data->secure_fdevice->miscdev);
>
> +err_depopulate:
> + /*
> + * A registered device node may already have been opened, so a user
> + * can hold a cctx reference. Drop only our reference instead of
> + * freeing the context directly.
> + */
> + spin_lock_irqsave(&data->lock, flags);
> + data->rpdev = NULL;
> + list_for_each_entry(user, &data->users, user)
> + fastrpc_notify_users(user);
> + spin_unlock_irqrestore(&data->lock, flags);
> +
> + of_platform_depopulate(rdev);
> + fastrpc_channel_ctx_put(data);
> + return err;
> +
> err_free_data:
> kfree(data);
> return err;
> }
[Severity: High]
Does moving dev_set_drvdata() and rdev->dma_mask = &data->dma_mask earlier
leave dangling pointers on rpdev->dev when of_platform_populate() or
fastrpc_device_register() fails?
rpmsg_dev_probe() creates rpdev->ept with fastrpc_rpmsg_callback() before
calling fastrpc_rpmsg_probe(), and only destroys the endpoint after probe
returns:
CPU0 CPU1 (<hardirq>)
rpmsg_dev_probe()
rpmsg_create_ept()
fastrpc_rpmsg_probe()
dev_set_drvdata(&rpdev->dev, data)
of_platform_populate() -> fails
kfree(data)
fastrpc_rpmsg_callback()
cctx = dev_get_drvdata(&rpdev->dev)
spin_lock_irqsave(&cctx->lock, ...)
<-- use-after-free
rpmsg_destroy_ept()
Because fastrpc_rpmsg_callback() only checks whether cctx is NULL, any
incoming rpmsg interrupt before rpmsg_destroy_ept() finishes will
dereference freed data at &cctx->lock and &cctx->ctx_idr. In addition,
device_unbind_cleanup() does not reset rdev->dma_mask, leaving it pointing
into the freed struct fastrpc_channel_ctx.
Clearing drvdata with dev_set_drvdata(&rpdev->dev, NULL) and resetting
rdev->dma_mask = NULL before releasing data in the error paths (or setting
drvdata only after fastrpc_device_register() succeeds) would avoid this
regression.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-fastrpc-probe-fixes-v3-0-3cd56d9d9a93@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-11-16 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 13:27 [PATCH v3 0/2] fastrpc: fix probe-time races between rpmsg and userspace Vinayak Katoch
2026-11-16 13:27 ` [PATCH v3 1/2] misc: fastrpc: fix NULL rpdev dereference when session alloc fails Vinayak Katoch
2026-11-16 13:50 ` sashiko-bot
2026-11-16 13:27 ` [PATCH v3 2/2] misc: fastrpc: fix init ordering race in rpmsg probe Vinayak Katoch
2026-11-16 13:51 ` sashiko-bot [this message]
2026-11-16 13:57 ` [PATCH v3 0/2] fastrpc: fix probe-time races between rpmsg and userspace Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217114@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vinayak.katoch@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.