All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Letian Jiang" <letian.jiang@outlook.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v3] perf docs: Correct JIT_CODE_UNWINDING_INFO specification
Date: Mon, 16 Nov 2026 14:21:13 +0000	[thread overview]
Message-ID: <sashiko-outbox-217155@kernel.org> (raw)
In-Reply-To: <CYXPR84MB34769BAF18918C609FCD3327827C2@CYXPR84MB3476.NAMPRD84.PROD.OUTLOOK.COM>

> The JIT_CODE_UNWINDING_INFO description places the EH Frame Header before
> the EH Frame. However, jit_add_eh_frame_info() uses the beginning of the
> unwinding data for .eh_frame and the trailing eh_frame_hdr_size bytes for
> .eh_frame_hdr.
> 
> Correct the unwinding_data description and the eh_frame_hdr_size field
> description to match the layout consumed by perf. Clarify that
> unwind_data_size includes both sections. perf subtracts
> eh_frame_hdr_size from unwind_data_size to obtain the .eh_frame size.
> 
> Also document that an unwinding record precedes and applies to the next
> JIT_CODE_LOAD record. perf caches the unwinding data and uses it when
> processing that load record.
> 
> Revise the mapped_size note to describe frame-pointer-based unwinding as
> a possibility depending on the backend and valid frame pointers in the
> generated code.
> 
> The libunwind-specific use case still matters: its EH Frame Header fields
> through fde_count are read directly from the ELF file, while lookup-table
> and EH Frame accesses require a mapping covering those addresses. An
> empty lookup table can trigger frame-pointer-based unwinding fallback
> without mapping the unwinding data. This does not impose the same access
> requirements on other unwinding backends.
> 
> Signed-off-by: Letian Jiang <letian.jiang@outlook.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/CYXPR84MB34769BAF18918C609FCD3327827C2@CYXPR84MB3476.NAMPRD84.PROD.OUTLOOK.COM?part=1


      reply	other threads:[~2026-11-16 14:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 15:40 [PATCH] perf docs: Correct JIT_CODE_UNWINDING_INFO specification Letian Jiang
2026-10-30 15:47 ` sashiko-bot
2026-10-31  6:12 ` [PATCH v2] " Letian Jiang
2026-10-31  6:15   ` sashiko-bot
2026-11-14  8:06   ` Namhyung Kim
2026-11-16 14:15   ` [PATCH v3] " Letian Jiang
2026-11-16 14:21     ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217155@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=letian.jiang@outlook.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.