From: sashiko-bot@kernel.org
To: "Alex Deucher" <alexander.deucher@amd.com>,
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdkfd: move TBA/TMA back to system memory
Date: Mon, 16 Nov 2026 14:29:04 +0000 [thread overview]
Message-ID: <sashiko-outbox-217163@kernel.org> (raw)
In-Reply-To: <20261116141731.1903647-1-alexander.deucher@amd.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/amdkfd: missing GC 9.4.4 and 9.5.0 in
kfd_process_device_init_cwsr_dgpu()
--
commit cc9ef3d2bb074c200e9b29b42b4feba716d6b86b
Author: Alex Deucher <alexander.deucher@amd.com>
drm/amdkfd: move TBA/TMA back to system memory
This commit restricts CWSR TBA/TMA VRAM allocation to specific MI GC IP
versions so that non-MI parts allocate TBA/TMA in GTT memory.
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index 546721b4d59ac..7a424184a4a3c 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -1554,7 +1554,10 @@ static int kfd_process_device_init_cwsr_dgpu(struct kfd_process_device *pdd)
> if (!dev->kfd->cwsr_enabled || !iosys_map_is_null(&qpd->cwsr_map) || !qpd->cwsr_base)
> return 0;
>
> - if (KFD_GC_VERSION(dev) >= IP_VERSION(9, 4, 2) && !dev->adev->apu_prefer_gtt)
> + if ((KFD_GC_VERSION(dev) == IP_VERSION(9, 4, 2) ||
> + KFD_GC_VERSION(dev) == IP_VERSION(9, 4, 3) ||
> + KFD_GC_VERSION(dev) == IP_VERSION(12, 1, 0)) &&
> + !dev->adev->apu_prefer_gtt)
> flags |= KFD_IOC_ALLOC_MEM_FLAGS_VRAM;
> else
> flags |= KFD_IOC_ALLOC_MEM_FLAGS_GTT;
[Severity: Medium]
Should this condition also include IP_VERSION(9, 4, 4) and
IP_VERSION(9, 5, 0)?
Other MI checks such as mqd_on_vram(), kfd_process_close_interrupt_drain(),
and KFD_SUPPORT_XNACK_PER_PROCESS() list GC 9.4.4 and 9.5.0 alongside 9.4.2
and 9.4.3. Omitting them here causes kfd_process_device_init_cwsr_dgpu()
to regress to KFD_IOC_ALLOC_MEM_FLAGS_GTT on those MI parts instead of
keeping TBA/TMA in VRAM.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116141731.1903647-1-alexander.deucher@amd.com?part=1
prev parent reply other threads:[~2026-11-16 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 14:17 [PATCH] drm/amdkfd: move TBA/TMA back to system memory Alex Deucher
2026-11-16 14:29 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217163@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.