All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: nhansp <nhan.094.vn@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: exynos: Add initial support for Samsung Galaxy Note8
Date: Mon, 16 Nov 2026 14:57:10 +0000	[thread overview]
Message-ID: <sashiko-outbox-217206@kernel.org> (raw)
In-Reply-To: <20261116-upstream-greatlte-dts-v1-2-768d49fb7d85@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: exynos: Signed-off-by and Author use handle instead
  of real name
--

commit 8021703a8198c1194682fa663237169e91d9a877
Author: nhansp <nhan.094.vn@gmail.com>

> arm64: dts: exynos: Add initial support for Samsung Galaxy Note8
>
> Samsung Galaxy Note8 (SM-N950N), codenamed greatlte, is a mobile phone
> from 2017. It features 6GB RAM, 64GB, 128GB or 256GB UFS 2.1, Exynos
> 8895 SoC and a 1440x2960 Super AMOLED display.
>
> This initial device tree enables SimpleFB, PSTORE and GPIO keys.
>
> Signed-off-by: nhansp <nhan.094.vn@gmail.com>

[Severity: High]
Both the Author header and the Signed-off-by trailer use the single-word
handle "nhansp".  Per Documentation/process/submitting-patches.rst, the
Developer's Certificate of Origin requires a known identity using a real
full name rather than a handle or pseudonym.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-upstream-greatlte-dts-v1-0-768d49fb7d85@gmail.com?part=2

      reply	other threads:[~2026-11-16 14:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 14:50 [PATCH 0/2] Add support for Samsung Galaxy Note8 (SM-N950N) nhansp
2026-11-16 14:50 ` [PATCH 1/2] dt-bindings: arm: samsung: Document greatlte board binding nhansp
2026-11-16 14:56   ` sashiko-bot
2026-11-18  8:21   ` Krzysztof Kozlowski
2026-11-16 14:50 ` [PATCH 2/2] arm64: dts: exynos: Add initial support for Samsung Galaxy Note8 nhansp
2026-11-16 14:57   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217206@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=nhan.094.vn@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.