All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jon Hunter" <jonathanh@nvidia.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 06/12] usb: xhci: tegra: Add support for Tegra238
Date: Mon, 16 Nov 2026 15:36:22 +0000	[thread overview]
Message-ID: <sashiko-outbox-217302@kernel.org> (raw)
In-Reply-To: <20261116-tegra-usb-v2-6-42efc03a9700@nvidia.com>

> Add XHCI support for the Tegra238 SoC which is similar to the Tegra234
> XHCI but only supports 3 USB2 and 3 USB3 ports compared to the 4 USB2
> and 4 USB3 ports on Tegra234.
> 
> Unlike other Tegra devices, Tegra238 does not have powergates for the
> USB host and Superspeed controllers and so for Tegra238 it is only
> necessary to manage the resets for these controllers. Add a
> 'has_powergates' variable to the SoC data to indicate if the Tegra
> device supports powergates for the USB host and Superspeed devices.
> For Tegra238 the driver uses devm_reset_control_get_shared() to
> obtain the 'xusb_ss' reset because it is shared with the Tegra XUDC
> driver.
> 
> Handle host and superspeed resets independently. During deactivation,
> attempt both assertions without rollback so a host reset failure does
> not retain the shared superspeed reset vote. During activation, deassert
> host before superspeed and unwind failed deassertions to keep the shared
> reset count balanced.
> 
> Finally, rename the functions tegra_xusb_powergate_partitions and
> tegra_xusb_unpowergate_partitions as tegra_xusb_deactivate and
> tegra_xusb_activate because now these only handle the resets for
> Tegra238.
> 
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-tegra-usb-v2-0-42efc03a9700@nvidia.com?part=6


  reply	other threads:[~2026-11-16 15:36 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 15:23 [PATCH v2 00/12] usb: Add support for Tegra238 and device support for Tegra264 Jon Hunter
2026-11-16 15:23 ` [PATCH v2 01/12] dt-bindings: usb: tegra234-xusb: Add required properties Jon Hunter
2026-11-16 15:33   ` sashiko-bot
2026-11-16 15:23 ` [PATCH v2 02/12] dt-bindings: usb: Add Tegra238 XUSB host controller support Jon Hunter
2026-11-16 15:38   ` sashiko-bot
2026-11-16 15:24 ` [PATCH v2 03/12] dt-bindings: usb: tegra-xudc: Add Tegra238 XUDC support Jon Hunter
2026-11-16 15:32   ` sashiko-bot
2026-11-16 15:24 ` [PATCH v2 04/12] dt-bindings: usb: tegra-xudc: Add Tegra264 " Jon Hunter
2026-11-16 15:32   ` sashiko-bot
2026-11-16 15:24 ` [PATCH v2 05/12] usb: xhci: tegra: Fix missing semi-colon Jon Hunter
2026-11-16 15:30   ` sashiko-bot
2026-11-16 15:24 ` [PATCH v2 06/12] usb: xhci: tegra: Add support for Tegra238 Jon Hunter
2026-11-16 15:36   ` sashiko-bot [this message]
2026-11-16 15:24 ` [PATCH v2 07/12] usb: gadget: tegra-xudc: Fix CNT65 configuration Jon Hunter
2026-11-16 15:29   ` sashiko-bot
2026-11-16 15:24 ` [PATCH v2 08/12] usb: gadget: tegra-xudc: Preserve runtime PM across system suspend Jon Hunter
2026-11-16 15:36   ` sashiko-bot
2026-11-16 15:24 ` [PATCH v2 09/12] usb: gadget: tegra-xudc: Add support for Tegra238 Jon Hunter
2026-11-16 15:54   ` sashiko-bot
2026-11-16 15:24 ` [PATCH v2 10/12] usb: gadget: tegra-xudc: Add SSPX register offset to SoC data Jon Hunter
2026-11-16 15:32   ` sashiko-bot
2026-11-16 15:24 ` [PATCH v2 11/12] usb: gadget: tegra-xudc: Add default settings " Jon Hunter
2026-11-16 15:34   ` sashiko-bot
2026-11-16 15:24 ` [PATCH v2 12/12] usb: gadget: tegra-xudc: Add support for Tegra264 Jon Hunter
2026-11-16 15:35   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217302@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.