From: sashiko-bot@kernel.org
To: "Sang-Heon Jeon" <ekffu200098@gmail.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] ext4: fix wrong unit of ratelimit_interval_ms sysfs attributes
Date: Mon, 16 Nov 2026 16:24:18 +0000 [thread overview]
Message-ID: <sashiko-outbox-217361@kernel.org> (raw)
In-Reply-To: <20261116161701.3664310-1-ekffu200098@gmail.com>
> The interval of ratelimit_state is in jiffies. But the
> ratelimit_interval_ms sysfs attributes are read and written without
> converting the interval, so the values are in milliseconds only if HZ
> is 1000.
>
> If HZ is 250, the default interval of 5 seconds is read as 1250, and
> writing 5000 sets the interval to 20 seconds.
>
> So use jiffies_to_msecs() and msecs_to_jiffies() when reading and
> writing. Also reject values which are too large for the interval.
>
> Fixes: efbed4dc5857 ("ext4: add ratelimiting to ext4 messages")
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116161701.3664310-1-ekffu200098@gmail.com?part=1
prev parent reply other threads:[~2026-11-16 16:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 16:17 [PATCH] ext4: fix wrong unit of ratelimit_interval_ms sysfs attributes Sang-Heon Jeon
2026-11-16 16:24 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217361@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ekffu200098@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.