From: sashiko-bot@kernel.org
To: "Yao Zhao" <dragonlinux@gmail.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 RESEND] perf annotate: fix annotate crash for fused instructions
Date: Mon, 16 Nov 2026 16:59:29 +0000 [thread overview]
Message-ID: <sashiko-outbox-217401@kernel.org> (raw)
In-Reply-To: <20261116165438.694835-1-dragonlinux@gmail.com>
> Function is_fused tries to find the previous fused instruction with the
> current conditional jump instruction in the annotate_line list.
> disasm_line is the container of annotate_line.
> The annotate_line list uses list_head and the head is in annotated_source:
> notes->src which is not an annotate_line, so it couldn't walk without
> checking the list_head. If so it will read annoted_source neighbour memory
> mistakenly and most likely cause crash.
>
> Fix the case where current instruction is a conditional jump and it is
> the first instruction in the disassembled list, the original code will
> walk to the head and treats it as disasm_line which is not.
>
> -------- backtrace --------
> #0 0x564dd8d5d5cd in ui__signal_backtrace setup.c:0
> #1 0x7f1737e3e6f0 libc.so.6[3e6f0]
> [ ... ]
> #16 0x564dd8bd7095 in _start help.c:109
>
> Fixes: 7efbcc8c075c ("perf annotate: Fix fused instr logic for assembly functions")
>
> Signed-off-by: Yao Zhao <dragonlinux@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116165438.694835-1-dragonlinux@gmail.com?part=1
prev parent reply other threads:[~2026-11-16 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 18:31 [PATCH v2] perf annotate: fix annotate crash for fused instructions Yao
2026-11-14 18:37 ` sashiko-bot
2026-11-16 16:54 ` [PATCH v2 RESEND] " Yao Zhao
2026-11-16 16:59 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217401@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dragonlinux@gmail.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.