All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Hungyu Lin" <dennylin0707@gmail.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] ext4: check RLIMIT_FSIZE in insert range
Date: Mon, 16 Nov 2026 19:02:53 +0000	[thread overview]
Message-ID: <sashiko-outbox-217523@kernel.org> (raw)
In-Reply-To: <20261116185810.82581-1-dennylin0707@gmail.com>

> ext4_insert_range() grows the file by len bytes but only checks the new
> size against s_maxbytes. FALLOC_FL_INSERT_RANGE can therefore make a
> file larger than RLIMIT_FSIZE allows, while ftruncate() and the
> fallocate() modes that extend a file fail with -EFBIG and SIGXFSZ. xfs,
> f2fs and ntfs3 already refuse to insert a range past the limit.
> 
> Fix this by validating the new size with inode_newsize_ok(), as
> ext4_do_fallocate() and ext4_zero_range() do.
> 
> Fixes: 331573febb6a ("ext4: Add support FALLOC_FL_INSERT_RANGE for fallocate")
> Cc: stable@vger.kernel.org
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116185810.82581-1-dennylin0707@gmail.com?part=1


      reply	other threads:[~2026-11-16 19:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 18:58 [PATCH] ext4: check RLIMIT_FSIZE in insert range Hungyu Lin
2026-11-16 19:02 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217523@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dennylin0707@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.