From: sashiko-bot@kernel.org
To: "Jayaraj Devaraj" <jayarajdmit@gmail.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: fu740: Disable pcie_aux clock if reset deassert fails
Date: Mon, 16 Nov 2026 20:16:05 +0000 [thread overview]
Message-ID: <sashiko-outbox-217644@kernel.org> (raw)
In-Reply-To: <20261116200912.156500-1-jayarajdmit@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] PCI: fu740: missing Fixes trailer for fu740_pcie_host_init()
clock leak fix
--
commit 5f0aad4ff6cb1ce1a8dd0a5f972ce2e2d06643f0
Author: Jayaraj Devaraj <jayarajdmit@gmail.com>
> PCI: fu740: Disable pcie_aux clock if reset deassert fails
>
> fu740_pcie_host_init() enables the pcie_aux clock and then returns
> without disabling it if reset_control_deassert() fails, leaving the
> clock enabled on the error path.
>
> Disable the clock before returning the error.
>
> Signed-off-by: Jayaraj Devaraj <jayarajdmit@gmail.com>
[Severity: Low]
This fixes a clock enable leak on the error path introduced with the
driver. Should it include:
Fixes: e7e21b3a339b ("PCI: fu740: Add SiFive FU740 PCIe host controller driver")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116200912.156500-1-jayarajdmit@gmail.com?part=1
prev parent reply other threads:[~2026-11-16 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 20:09 [PATCH] PCI: fu740: Disable pcie_aux clock if reset deassert fails Jayaraj Devaraj
2026-11-16 20:09 ` Jayaraj Devaraj
2026-11-16 20:16 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217644@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=jayarajdmit@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.