All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Justinien Bouron" <jbouron@amazon.com>, linux-ide@vger.kernel.org
Cc: dlemoal@kernel.org, cassel@kernel.org
Subject: Re: [PATCH] ata: libata-core: Add max sector quirk to INTEL SSDSCKKB240G8
Date: Mon, 16 Nov 2026 21:00:53 +0000	[thread overview]
Message-ID: <sashiko-outbox-217686@kernel.org> (raw)
In-Reply-To: <20261116205430.44305-1-jbouron@amazon.com>

Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [High] ata: libata: quirk shadowing in ata_dev_quirks() [1]
--

commit 139b2f80d245bb5cb2eb4919933ec350b21131cd
Author: Justinien Bouron <jbouron@amazon.com>

ata: libata-core: Add max sector quirk to INTEL SSDSCKKB240G8

This commit adds an 8191 max_sectors quirk for INTEL SSDSCKKB240G8 drives
with firmware XC311102 to avoid FPDMA timeout errors.

> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 5ff45a5cbfe4a..2a5ca1b9ee5c0 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c

[ ... ]

> @@ -4474,6 +4475,8 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
>  						ATA_QUIRK_MAX_SEC },
>  	{ "INTEL*SSDSC2CT*",		NULL,	ATA_QUIRK_ZERO_AFTER_TRIM |
>  						ATA_QUIRK_NO_FUA },
> +	{ "INTEL SSDSCKKB240G8", "XC311102",	ATA_QUIRK_ZERO_AFTER_TRIM |
> +						ATA_QUIRK_MAX_SEC },

[Severity: High]
This problem wasn't introduced by this patch, but does the early exact match
in __ata_dev_quirks[] shadow the later wildcard entries for
WDC WD2500JD-00HBB0 and WDC WD3200JD-00KLB0 [1]?

Because ata_dev_quirks() returns on the first matching entry in
__ata_dev_quirks[], this new entry includes ATA_QUIRK_ZERO_AFTER_TRIM ahead
of the INTEL*SSD* wildcard.  Earlier in the same table, the exact-match
entries for WDC WD3200JD-00KLB0 and WDC WD2500JD-00HBB0 specify only
ATA_QUIRK_BROKEN_HPA:

drivers/ata/libata-core.c:__ata_dev_quirks[] = {
	...
	{ "WDC WD3200JD-00KLB0", "WD-WCAMR1130137", ATA_QUIRK_BROKEN_HPA },
	{ "WDC WD2500JD-00HBB0", "WD-WMAL71490727", ATA_QUIRK_BROKEN_HPA },
	...
	{ "WDC WD2500JD-*",		NULL,	ATA_QUIRK_WD_BROKEN_LPM |
						ATA_QUIRK_NO_FUA },
	{ "WDC WD3000JD-*",		NULL,	ATA_QUIRK_WD_BROKEN_LPM },
	{ "WDC WD3200JD-*",		NULL,	ATA_QUIRK_WD_BROKEN_LPM },
	...
};

When either drive matches its exact entry, ata_dev_quirks() returns without
reaching the WDC WD2500JD-* or WDC WD3200JD-* wildcard entries, leaving
ATA_QUIRK_WD_BROKEN_LPM and ATA_QUIRK_NO_FUA unapplied and exposing those
drives to broken LPM link instability and unsupported FUA I/O errors.

[1] https://sashiko.dev/#/bug/linux-1d8177db-a3fc-48ef-adce-d0515b20b43a

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116205430.44305-1-jbouron@amazon.com?part=1

  reply	other threads:[~2026-11-16 21:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 20:54 [PATCH] ata: libata-core: Add max sector quirk to INTEL SSDSCKKB240G8 Justinien Bouron
2026-11-16 21:00 ` sashiko-bot [this message]
2026-11-16 21:39 ` Damien Le Moal
2026-11-17 12:45 ` Niklas Cassel
2026-11-17 12:55   ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217686@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=jbouron@amazon.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.