From: sashiko-bot@kernel.org
To: "Joseph Telaak" <joseph@telaak.dev>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH net-next v4 1/2] dt-bindings: net: dsa: lantiq,gswip: add reset-gpios
Date: Mon, 16 Nov 2026 22:34:06 +0000 [thread overview]
Message-ID: <sashiko-outbox-217793@kernel.org> (raw)
In-Reply-To: <20261115-mxl-gsw1xx-reset-v4-1-4ecd18c922e2@telaak.dev>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: net: dsa: lantiq,gswip: split GSW1xx into separate
schema
--
commit 01a5dca493e3ff68856f4f4d443a02d28d47883f
Author: Joseph Telaak <joseph@telaak.dev>
dt-bindings: net: dsa: lantiq,gswip: add reset-gpios
This commit adds the reset-gpios property for standalone GSW1xx switches and
notes its effect on the default RGMII slew-rate configuration.
> diff --git a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> index 49af5573e452d..89f78a1bc113d 100644
> --- a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> @@ -40,6 +40,11 @@ properties:
> - const: mdio
> - const: mii
>
> + reset-gpios:
> + maxItems: 1
> + description:
> + GPIO connected to the hardware reset input of a standalone switch.
> +
> mdio:
> $ref: /schemas/net/mdio.yaml#
> unevaluatedProperties: false
[ ... ]
> @@ -173,6 +180,7 @@ allOf:
> mdio:
> required:
> - compatible
> + reset-gpios: false
> else:
> properties:
> reg:
[Severity: Low]
This isn't a bug, but would it make sense to split the standalone MDIO-based
GSW1xx switches into a separate binding schema instead of adding more
per-compatible conditionals here?
The SoC-integrated MMIO GSWIP variants and the standalone MDIO GSW1xx switches
sit on different buses and already require overriding or disallowing nearly
every top-level property outside compatible and ports (reg, reg-names, mdio,
gphy-fw, and now reset-gpios) in the allOf if-then-else block, alongside the
MaxLinear-specific port properties.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261115-mxl-gsw1xx-reset-v4-0-4ecd18c922e2@telaak.dev?part=1
next prev parent reply other threads:[~2026-11-16 22:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 22:33 [PATCH net-next v4 0/2] net: dsa: mxl-gsw1xx: reset the switch through reset-gpios Joseph Telaak
2026-11-15 22:33 ` Joseph Telaak via B4 Relay
2026-11-15 22:33 ` [PATCH net-next v4 1/2] dt-bindings: net: dsa: lantiq,gswip: add reset-gpios Joseph Telaak
2026-11-15 22:33 ` Joseph Telaak via B4 Relay
2026-11-16 22:34 ` sashiko-bot [this message]
2026-11-15 22:33 ` [PATCH net-next v4 2/2] net: dsa: mxl-gsw1xx: reset the switch through reset-gpios Joseph Telaak
2026-11-15 22:33 ` Joseph Telaak via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217793@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joseph@telaak.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.