All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: erebion <erebion@erebion.eu>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v5 08/12] arm64: dts: qcom: sm6350-lena: Enable PMK8350
Date: Mon, 16 Nov 2026 23:01:25 +0000	[thread overview]
Message-ID: <sashiko-outbox-217835@kernel.org> (raw)
In-Reply-To: <20261116-pdx213-upstream-3-v5-8-7318a19806eb@erebion.eu>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: invalid handle in Signed-off-by trailer
--

commit 653bcdb19432d3b2792a7f5615a893fd67bfe22e
Author: erebion <erebion@erebion.eu>

> arm64: dts: qcom: sm6350-lena: Enable PMK8350
>
> Configure and enable nodes for PMK8350 on the Xperia 10 III.
>
> The phone has two PMICs which have a PON block, disable the PMK8350
>  PON and keep the PM6350 PON, as only one should be enabled.
>
> Signed-off-by: erebion <erebion@erebion.eu>

[Severity: High]
Per Documentation/process/submitting-patches.rst, the Developer's
Certificate of Origin requires a real human name in the Author header
and Signed-off-by trailer rather than a single-word handle or username.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-pdx213-upstream-3-v5-0-7318a19806eb@erebion.eu?part=8

  reply	other threads:[~2026-11-16 23:01 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 22:50 [PATCH v5 00/12] Enable more nodes for the Xperia 10 III erebion
2026-11-16 22:50 ` [PATCH v5 01/12] arm64: dts: qcom: sm6350-lena: Add flash LED erebion
2026-11-16 22:55   ` sashiko-bot
2026-11-16 23:04     ` erebion
2026-11-16 22:50 ` [PATCH v5 02/12] arm64: dts: qcom: sm6350-lena: rename touch-en-regulator erebion
2026-11-16 22:55   ` sashiko-bot
2026-11-16 23:06     ` erebion
2026-11-16 22:50 ` [PATCH v5 03/12] arm64: dts: qcom: sm6350-lena: Add qcom,rmtfs-mem node erebion
2026-11-16 22:55   ` sashiko-bot
2026-11-16 23:06     ` erebion
2026-11-16 22:50 ` [PATCH v5 04/12] arm64: dts: qcom: sm6350-lena: Enable ADSP, CDSP, IPA & MPSS erebion
2026-11-16 22:56   ` sashiko-bot
2026-11-16 23:06     ` erebion
2026-11-17 11:31   ` Luca Weiss
2026-11-16 22:50 ` [PATCH v5 05/12] arm64: dts: qcom: sm6350-lena: Enable Bluetooth erebion
2026-11-16 23:11   ` sashiko-bot
2026-11-16 23:17     ` erebion
2026-11-16 22:50 ` [PATCH v5 06/12] arm64: dts: qcom: sm6350-lena: Enable wifi erebion
2026-11-16 22:56   ` sashiko-bot
2026-11-16 23:06     ` erebion
2026-11-16 22:50 ` [PATCH v5 07/12] arm64: dts: qcom: sm6350-lena: Enable PM7250B erebion
2026-11-16 23:06   ` sashiko-bot
2026-11-16 23:06     ` erebion
2026-11-17 12:05   ` Luca Weiss
2026-11-16 22:50 ` [PATCH v5 08/12] arm64: dts: qcom: sm6350-lena: Enable PMK8350 erebion
2026-11-16 23:01   ` sashiko-bot [this message]
2026-11-16 23:07     ` erebion
2026-11-17 12:02   ` Luca Weiss
2026-11-16 22:50 ` [PATCH v5 09/12] arm64: dts: qcom: sm6350-lena: Add PM7250B thermals erebion
2026-11-16 23:03   ` sashiko-bot
2026-11-16 23:07     ` erebion
2026-11-17 12:06   ` Luca Weiss
2026-11-17 18:13     ` erebion
2026-11-16 22:50 ` [PATCH v5 10/12] arm64: dts: qcom: sm6350-lena: Add PMK8350 thermals erebion
2026-11-16 23:00   ` sashiko-bot
2026-11-16 23:07     ` erebion
2026-11-17 12:08   ` Luca Weiss
2026-11-16 22:50 ` [PATCH v5 11/12] arm64: dts: qcom: sm6350-lena: Add PM6150L thermals erebion
2026-11-16 23:02   ` sashiko-bot
2026-11-16 23:07     ` erebion
2026-11-17 12:10   ` Luca Weiss
2026-11-16 22:50 ` [PATCH v5 12/12] arm64: dts: qcom: sm6350-lena: enable remaining i2c busses erebion
2026-11-16 22:59   ` sashiko-bot
2026-11-16 23:08     ` erebion
2026-11-17 12:11   ` Luca Weiss
2026-11-17 18:16     ` erebion

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217835@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=erebion@erebion.eu \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.