From: sashiko-bot@kernel.org
To: "Bobby Eshleman" <bobbyeshleman@meta.com>
Cc: virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH net] vsock: only deliver taps to namespaces that can reach the device
Date: Mon, 16 Nov 2026 23:53:02 +0000 [thread overview]
Message-ID: <sashiko-outbox-217935@kernel.org> (raw)
In-Reply-To: <20261116-vsock-tap-net-v1-1-7e24f45adad3@meta.com>
> vsock_deliver_tap() clones every packet to every vsockmon device on the
> system. Creating one needs only CAP_NET_ADMIN in the owning user
> namespace, so an unprivileged user can capture the traffic of local mode
> namespaces.
>
> Pass the packet's netns to vsock_deliver_tap() and only deliver to
> devices that pass vsock_net_check_mode(), the same rule socket lookups
> use. vhost passes the vhost_vsock netns, loopback the sending socket's
> netns, and virtio-vsock NULL (global mode).
>
> Fixes: a69686327e42 ("vsock: add netns support to virtio transports")
> Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-vsock-tap-net-v1-1-7e24f45adad3@meta.com?part=1
prev parent reply other threads:[~2026-11-16 23:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 23:46 [PATCH net] vsock: only deliver taps to namespaces that can reach the device Bobby Eshleman
2026-11-16 23:52 ` netdev-bot+sinfo
2026-11-17 1:20 ` Bobby Eshleman
2026-11-16 23:53 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217935@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bobbyeshleman@meta.com \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.