All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Arnaldo Carvalho de Melo" <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v4 12/12] perf test: Skip the LBR inline unwinding check when unsupported
Date: Tue, 17 Nov 2026 00:06:42 +0000	[thread overview]
Message-ID: <sashiko-outbox-217977@kernel.org> (raw)
In-Reply-To: <20261116234659.3950531-13-acme@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] perf test: test_lbr() grep misses EOPNOTSUPP branch stack error
  string
--

commit 0391fa9c2628a460f3c842d979bf69a0aa07c146
Author: Arnaldo Carvalho de Melo <acme@redhat.com>

perf test: Skip the LBR inline unwinding check when unsupported

This commit updates the addr2line_inlines shell test to check the error
output from perf record --call-graph lbr and skip the test with exit status
2 when LBR recording is rejected by the PMU.

> diff --git a/tools/perf/tests/shell/addr2line_inlines.sh b/tools/perf/tests/shell/addr2line_inlines.sh
> index e8754ef2d7f21..be0bfb70143a1 100755
> --- a/tools/perf/tests/shell/addr2line_inlines.sh
> +++ b/tools/perf/tests/shell/addr2line_inlines.sh

[ ... ]

> @@ -71,7 +73,22 @@ test_lbr() {
>      fi
>  
>      # Record data. Currently only dwarf callchains support inlined functions.
> -    perf record --call-graph lbr -e cycles:u -o "${perf_data}" -- perf test -w inlineloop 1
> +    # Some PMUs advertise branches but reject branch sampling for cycles, e.g.
> +    # AMD BRS, which only samples its own retired branches event.
> +    if ! perf record --call-graph lbr -e cycles:u -o "${perf_data}" -- \
> +            perf test -w inlineloop 1 2> "${perf_record_err}"
> +    then
> +        if grep -q -e "Invalid argument" -e "not supported" "${perf_record_err}"
> +        then
> +            echo "Skip: LBR not supported by the PMU"
> +            lbr_skipped=1
> +        else
> +            cat "${perf_record_err}"
> +            echo "Inline unwinding lbr verification test [Failed to record]"
> +            err=1
> +        fi
> +        return
> +    fi

[Severity: Low]
Does this grep miss the EOPNOTSUPP error message emitted when the PMU rejects
--call-graph lbr?

On CPUs that expose caps/branches but return -EOPNOTSUPP for
PERF_SAMPLE_BRANCH_CALL_STACK (such as AMD Zen 4/5 with LBRv2 in
amd_pmu_lbr_setup_filter()), evsel__open_strerror() formats EOPNOTSUPP with
"doesn't support" rather than strerror(EOPNOTSUPP) ("Operation not
supported"):

tools/perf/util/evsel.c:evsel__open_strerror() {
	...
	case EOPNOTSUPP:
		if (evsel->core.attr.sample_type & PERF_SAMPLE_BRANCH_STACK)
			return scnprintf(msg, size,
	"%s: PMU Hardware or event type doesn't support branch stack sampling.",
					 evsel__name(evsel));
	...
}

As a result, the grep does not match and test_lbr() still fails the test
with err=1 instead of skipping.  Matching "doesn't support" as well would
handle EOPNOTSUPP.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116234659.3950531-1-acme@kernel.org?part=12

      reply	other threads:[~2026-11-17  0:06 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 23:46 [PATCH v4 0/12] perf coverage: A harness for perf, and the fixes it found Arnaldo Carvalho de Melo
2026-11-16 23:46 ` [PATCH v4 01/12] perf scripts: Add a coverage harness for perf Arnaldo Carvalho de Melo
2026-11-16 23:55   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 02/12] perf annotate: Handle absolute addressing in data type profiling Arnaldo Carvalho de Melo
2026-11-17  0:03   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 03/12] perf annotate-data: Resolve DW_OP_addrx global variables Arnaldo Carvalho de Melo
2026-11-17  0:03   ` sashiko-bot
2026-11-17  0:10   ` Arnaldo Carvalho de Melo
2026-11-16 23:46 ` [PATCH v4 04/12] perf tests: Exercise the flexible array member path Arnaldo Carvalho de Melo
2026-11-16 23:56   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 05/12] perf annotate-data: Count flexible array accesses for the whole struct Arnaldo Carvalho de Melo
2026-11-16 23:55   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 06/12] perf tests: Exercise data type resolution from a register Arnaldo Carvalho de Melo
2026-11-16 23:55   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 07/12] perf annotate: Print the stats after the annotations Arnaldo Carvalho de Melo
2026-11-16 23:55   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 08/12] perf tests: Silence the libbfd probe in build-test Arnaldo Carvalho de Melo
2026-11-16 23:50   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 09/12] perf build: Record the display-only features in FEATURE-DUMP Arnaldo Carvalho de Melo
2026-11-17  0:00   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 10/12] perf tests: Fix the Intel PT virtual LBR check Arnaldo Carvalho de Melo
2026-11-17  0:06   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 11/12] perf test: Drop samples without an IP in the dlfilter test Arnaldo Carvalho de Melo
2026-11-16 23:56   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 12/12] perf test: Skip the LBR inline unwinding check when unsupported Arnaldo Carvalho de Melo
2026-11-17  0:06   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217977@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=acme@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.