From: sashiko-bot@kernel.org
To: "Jesus Narvaez" <jesus.narvaez@intel.com>,
intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v4 1/2] drm/xe: Add has_sem64 bit to graphics/media IP descriptors
Date: Tue, 17 Nov 2026 01:10:33 +0000 [thread overview]
Message-ID: <sashiko-outbox-218035@kernel.org> (raw)
In-Reply-To: <20261117005534.2322094-5-jesus.narvaez@intel.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] drm/xe: missing has_sem64 flag in graphics_xe3p_xpc
descriptor
- [Low] drm/xe: commit message mismatch on has_sem64 resolution in
xe_info_init()
--
commit f84a9b352b46badc7204ec8d1017a8868a404b81
Author: Tangudu Tilak Tirumalesh <tilak.tirumalesh.tangudu@intel.com>
drm/xe: Add has_sem64 bit to graphics/media IP descriptors
This commit adds a has_sem64 capability bit to graphics and media IP
descriptors and resolves gt->info.has_sem64 across the primary and media
GTs on each tile.
> The bit indicates whether the GT's command streamer supports the
> MI_SEMAPHORE_WAIT_64 instruction. A platform's CS must not mix
> MI_SEMAPHORE_WAIT and MI_SEMAPHORE_WAIT_64 within a context or across
> context submissions, so both the primary and media GT must agree before
> either one enables sem64; resolve has_sem64 once in xe_info_init() and
> hand the single value to both GT allocators.
[Severity: Low]
Does the commit message match how has_sem64 is resolved?
alloc_primary_gt() and alloc_media_gt() each compute gt->info.has_sem64
independently from their IP descriptor and stepping, and xe_info_init()
clears both fields afterward if the two GTs disagree rather than passing
a pre-resolved value into the allocators.
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 3bd68ed9daa81..dd56c9c7b92bb 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -127,6 +127,7 @@ static const struct xe_graphics_desc graphics_xe3p_lpg = {
> .multi_queue_engine_class_mask = BIT(XE_ENGINE_CLASS_COPY) | BIT(XE_ENGINE_CLASS_COMPUTE),
> .num_geometry_xecore_fuse_regs = 3,
> .num_compute_xecore_fuse_regs = 3,
> + .has_sem64 = 1,
> };
>
> static const struct xe_graphics_desc graphics_xe3p_xpc = {
> @@ -153,11 +154,20 @@ static const struct xe_media_desc media_xelpmp = {
> .hw_engine_mask =
> GENMASK(XE_HW_ENGINE_VCS7, XE_HW_ENGINE_VCS0) |
> GENMASK(XE_HW_ENGINE_VECS3, XE_HW_ENGINE_VECS0) |
> - BIT(XE_HW_ENGINE_GSCCS0)
> + BIT(XE_HW_ENGINE_GSCCS0),
> +};
> +
> +static const struct xe_media_desc media_xe3p_lpm = {
> + .hw_engine_mask =
> + GENMASK(XE_HW_ENGINE_VCS7, XE_HW_ENGINE_VCS0) |
> + GENMASK(XE_HW_ENGINE_VECS3, XE_HW_ENGINE_VECS0) |
> + BIT(XE_HW_ENGINE_GSCCS0),
> + .has_sem64 = 1,
> };
>
> static const struct xe_media_desc media_xe3p_hpm = {
> .has_uncorrectable_error_reporting = 1,
> + .has_sem64 = 1,
> .hw_engine_mask =
> GENMASK(XE_HW_ENGINE_VCS7, XE_HW_ENGINE_VCS0) |
> GENMASK(XE_HW_ENGINE_VECS3, XE_HW_ENGINE_VECS0) |
[Severity: Medium]
Should graphics_xe3p_xpc also set .has_sem64 = 1?
alloc_primary_gt() specifically scopes the STEP_B0 check to graphics IP
35.10 (GRAPHICS_VERx100(xe) == 3510), and media_xe3p_hpm (35.03) sets
.has_sem64 = 1. Because graphics_xe3p_xpc (35.11) omits .has_sem64 = 1,
primary_gt->info.has_sem64 remains false on Xe3p_XPC and xe_info_init()
clears media_gt->info.has_sem64 back to false on its companion
Xe3p_HPM media GT as well.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117005534.2322094-4-jesus.narvaez@intel.com?part=1
next prev parent reply other threads:[~2026-11-17 1:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 0:55 [PATCH v4 0/2] drm/xe: Handle GuC semaphore instruction field check error Jesus Narvaez
2026-11-17 0:55 ` [PATCH v4 1/2] drm/xe: Add has_sem64 bit to graphics/media IP descriptors Jesus Narvaez
2026-11-17 1:10 ` sashiko-bot [this message]
2026-11-17 0:55 ` [PATCH v4 2/2] drm/xe/guc: Handle GuC semaphore instruction field check error Jesus Narvaez
2026-11-17 1:14 ` ✗ CI.checkpatch: warning for drm/xe: " Patchwork
2026-11-17 1:16 ` ✓ CI.KUnit: success " Patchwork
2026-11-17 1:48 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-11-17 16:40 ` ✓ Xe.CI.FULL: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218035@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jesus.narvaez@intel.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.