From: sashiko-bot@kernel.org
To: "Kyrie Wu" <kyrie.wu@mediatek.com>, devicetree@vger.kernel.org
Cc: robh@kernel.org, conor+dt@kernel.org, media-ci@linuxtv.org
Subject: Re: [PATCH v9 08/14] media: dt-bindings: mediatek,vcodec-subdev-decoder: Add MT8196
Date: Tue, 17 Nov 2026 03:39:24 +0000 [thread overview]
Message-ID: <sashiko-outbox-218146@kernel.org> (raw)
In-Reply-To: <20261117032950.1425556-9-kyrie.wu@mediatek.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] media: dt-bindings: unwieldy per-SoC conditionals and missing
vcp: false
--
commit b84ac51492845b481ba538f65b5ea25cbc4c838d
Author: Kyrie Wu <kyrie.wu@mediatek.com>
media: dt-bindings: mediatek,vcodec-subdev-decoder: Add MT8196
This commit adds the mediatek,mt8196-vcodec-dec compatible string and
mediatek,vcp property to the MediaTek video decoder subdev binding, while
moving the mediatek,scp requirement to existing SoCs.
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> index d1d209cbbd43a..c06d8a8a607d0 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
[ ... ]
> @@ -179,6 +184,51 @@ then:
> - interrupts
>
> allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8196-vcodec-dec
> +
> + then:
> + required:
> + - mediatek,vcp
> +
> + properties:
> + mediatek,scp: false
> +
> + patternProperties:
> + '^video-codec@[0-9a-f]+$':
> + properties:
> + compatible:
> + enum:
> + - mediatek,mtk-vcodec-core
> + - mediatek,mtk-vcodec-lat
> +
> + clocks:
> + maxItems: 4
> +
> + clock-names:
> + items:
> + - const: sel
> + - const: vdec
> + - const: lat
> + - const: top
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - mediatek,mt8192-vcodec-dec
> + - mediatek,mt8186-vcodec-dec
> + - mediatek,mt8188-vcodec-dec
> + - mediatek,mt8195-vcodec-dec
> +
> + then:
> + required:
> + - mediatek,scp
[Severity: Low]
Should this binding be split into separate schema documents instead of adding
more per-compatible if-then blocks to allOf? MT8196 diverges in both its
firmware processor (VCP vs SCP) and its video-codec child node constraints on
top of the existing single-hardware and multi-hardware SoC variants, which
makes the conditionals in this single schema unwieldy and duplicates the
four-item clock-names list from mediatek,mt8195-vcodec-dec.
Also, if kept in a shared schema, the SCP-based compatible branch does not set
mediatek,vcp: false, which leaves mediatek,vcp allowed on those SoCs during
dtbs_check. Finally, the SoC architecture list in the top-level description
is not updated to mention MT8196.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117032950.1425556-1-kyrie.wu@mediatek.com?part=8
next prev parent reply other threads:[~2026-11-17 3:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 3:29 [PATCH v9 00/14] media: mediatek: vcodec: support video decoder in mt8196 Kyrie Wu
2026-11-17 3:29 ` [PATCH v9 01/14] media: mediatek: vcodec: support vcp architecture Kyrie Wu
2026-11-17 3:29 ` [PATCH v9 02/14] media: mediatek: vcodec: add driver to support vcp Kyrie Wu
2026-11-17 3:55 ` sashiko-bot
2026-11-17 3:29 ` [PATCH v9 03/14] media: mediatek: vcodec: add driver to support vcp encoder Kyrie Wu
2026-11-17 3:53 ` sashiko-bot
2026-11-17 3:29 ` [PATCH v9 04/14] media: mediatek: vcodec: get different firmware ipi id Kyrie Wu
2026-11-17 3:53 ` sashiko-bot
2026-11-17 3:29 ` [PATCH v9 05/14] media: mediatek: vcodec: get share memory address Kyrie Wu
2026-11-17 3:58 ` sashiko-bot
2026-11-17 3:29 ` [PATCH v9 06/14] media: mediatek: vcodec: add debug information Kyrie Wu
2026-11-17 3:29 ` [PATCH v9 07/14] media: mediatek: vcodec: send share memory address to vcp Kyrie Wu
2026-11-17 3:29 ` [PATCH v9 08/14] media: dt-bindings: mediatek,vcodec-subdev-decoder: Add MT8196 Kyrie Wu
2026-11-17 3:39 ` sashiko-bot [this message]
2026-11-17 3:29 ` [PATCH v9 09/14] media: mediatek: vcodec: add decoder compatible to support mt8196 Kyrie Wu
2026-11-17 3:29 ` [PATCH v9 10/14] media: mediatek: vcodec: define MT8196 vcodec levels Kyrie Wu
2026-11-17 3:29 ` [PATCH v9 11/14] media: mediatek: vcodec: support 36bit iova address Kyrie Wu
2026-11-17 3:29 ` [PATCH v9 12/14] media: mediatek: vcodec: clean xpc status Kyrie Wu
2026-11-17 4:04 ` sashiko-bot
2026-11-17 3:29 ` [PATCH v9 13/14] media: mediatek: decoder: fill av1 buffer size with picinfo Kyrie Wu
2026-11-17 3:29 ` [PATCH v9 14/14] media: mediatek: decoder: support av1 extend vsi Kyrie Wu
2026-11-17 4:14 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218146@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kyrie.wu@mediatek.com \
--cc=media-ci@linuxtv.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.