All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Cristian Filipescu" <filipescu.cristian@gmail.com>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org
Cc: linux-sunxi@lists.linux.dev, robh@kernel.org,
	conor+dt@kernel.org, lee@kernel.org
Subject: Re: [PATCH RFC] leds: DT: migrating existing labels to function/color
Date: Tue, 17 Nov 2026 05:20:46 +0000	[thread overview]
Message-ID: <sashiko-outbox-218197@kernel.org> (raw)
In-Reply-To: <179489221679.1.1429296960451969532.led-label-policy-rfc@gmail.com>

Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [High] arm64: dts: allwinner: missing Signed-off-by trailer and RFC
  commit format
- [Medium] arm64: dts: allwinner: removing LED label changes sysfs and
  GPIO names
- [Low] arm64: dts: allwinner: inaccurate DTB count and Orange Pi 3 LTS
  claim in log
--

commit 9235c19cbef601645f52663823784ba072327e48
Author: Cristian Filipescu <filipescu.cristian@gmail.com>

> leds: DT: migrating existing labels to function/color
>
> Hi,
>
> The common LED binding deprecates label in favour of function and color.
> Is removing existing labels desirable when it changes established LED class
> names, or should existing board descriptions retain them for compatibility?
>
> For example, the Orange Pi H6 descriptions could replace their labels with
> LED_FUNCTION_POWER/STATUS and LED_COLOR_ID_RED/GREEN. With gpio-leds, this
> would change the names under /sys/class/leds:
>
>   orangepi:red:power    -> red:power
>   orangepi:green:status -> green:status
>
> The example below changes two files and affects Orange Pi 3, 3 LTS, Lite2
> and One Plus. GPIOs, polarity, pinctrl, defaults and triggers are unchanged.
> All four DTBs compile before and after; comparison found only the intended
> label/function/color changes. The renamed LEDs have not been tested on
> hardware.

[Severity: Low]
Is the list of four affected DTBs accurate?

arch/arm64/boot/dts/allwinner/Makefile only builds three H6 Orange Pi DTBs:
sun50i-h6-orangepi-3.dtb (from sun50i-h6-orangepi-3.dts) and
sun50i-h6-orangepi-lite2.dtb and sun50i-h6-orangepi-one-plus.dtb (which
include sun50i-h6-orangepi.dtsi).  There is no Orange Pi 3 LTS device tree
in the kernel tree.

> I was thinking of converting all the deprecated LED labels, but I wanted
> to see if this was something maintainers wanted, since it would touch a lot
> of files. Would you prefer retaining existing labels (potentially adding
> function and color alongside them), or reviewing migrations with the name
> changes explicitly documented?
>
> This is a discussion example, not a patch for inclusion. Preparation and
> static checks were assisted by OpenAI Codex.
>
> Thanks,
> Cristian

[Severity: High]
This commit has no Signed-off-by: trailer, uses an RFC email body instead
of a declarative changelog, and uses "leds: DT: ..." rather than the
"arm64: dts: allwinner: h6: ..." subject prefix.

> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
> index ce82aa265cfd1..8e411705769b1 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
> @@ -8,6 +8,7 @@
>  #include "sun50i-h6-gpu-opp.dtsi"
>  
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
>  
>  / {
>  	model = "OrangePi 3";
> @@ -45,13 +46,15 @@ leds {
>  		compatible = "gpio-leds";
>  
>  		led-0 {
> -			label = "orangepi:red:power";
> +			function = LED_FUNCTION_POWER;
> +			color = <LED_COLOR_ID_RED>;
>  			gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
>  			default-state = "on";
>  		};
>  
>  		led-1 {
> -			label = "orangepi:green:status";
> +			function = LED_FUNCTION_STATUS;
> +			color = <LED_COLOR_ID_GREEN>;
>  			gpios = <&r_pio 0 7 GPIO_ACTIVE_HIGH>; /* PL7 */
>  		};
>  	};

[Severity: Medium]
Does removing label here and in sun50i-h6-orangepi.dtsi cause a userspace
regression by renaming the sysfs entries and GPIO consumer names?

When gpio_leds_create() registers these nodes without label,
led_compose_name() formats the LED names as "red:power" and "green:status"
instead of "orangepi:red:power" and "orangepi:green:status", and passes the
new kobject name to gpiod_set_consumer_name().  That breaks userspace
scripts and board configurations that rely on the existing /sys/class/leds/
paths and GPIO consumer labels on Orange Pi 3, Lite2, and One Plus.

Documentation/devicetree/bindings/leds/common.yaml leaves "deprecated: true"
off the label property so existing device trees can keep their established
names without dtbs_check warnings.  Note also that adding function alongside
an existing label has no effect, because led_parse_fwnode_props() returns
immediately after reading label:

drivers/leds/led-core.c:led_parse_fwnode_props() {
	...
	if (fwnode_property_present(fwnode, "label")) {
		ret = fwnode_property_read_string(fwnode, "label", &props->label);
		if (ret)
			dev_err(dev, "Error parsing 'label' property (%d)\n", ret);
		return;
	}
	...
}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/179489221679.1.1429296960451969532.led-label-policy-rfc@gmail.com?part=1

      reply	other threads:[~2026-11-17  5:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  5:10 [PATCH RFC] leds: DT: migrating existing labels to function/color Cristian Filipescu via B4 Relay
2026-11-17  5:10 ` Cristian Filipescu
2026-11-17  5:20 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218197@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=filipescu.cristian@gmail.com \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.